aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2021-02-19 15:30:44 +0100
committerGitHub <noreply@github.com>2021-02-19 15:30:44 +0100
commitcd5be31bb05eb926bfa37e3bd586b73cd189bc20 (patch)
tree5806ddab2c5411ca74a32929828f7f3df9ba1084
parentf124b885f64530ff3167512b12fb3ffc98818415 (diff)
parent8425fd79d38f593f4a54cf341fdf2938ac8b4f35 (diff)
Merge pull request #16595 from vespa-engine/bjorncs/reenable-test
Handle alternative error message for incompatible TLS protocol version
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/SslHandshakeFailure.java3
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/jdisc/http/server/jetty/HttpServerTest.java2
2 files changed, 2 insertions, 3 deletions
diff --git a/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/SslHandshakeFailure.java b/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/SslHandshakeFailure.java
index 64f70564137..57b41661cb1 100644
--- a/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/SslHandshakeFailure.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/SslHandshakeFailure.java
@@ -16,7 +16,8 @@ enum SslHandshakeFailure {
MetricDefinitions.SSL_HANDSHAKE_FAILURE_INCOMPATIBLE_PROTOCOLS,
"INCOMPATIBLE_CLIENT_PROTOCOLS",
"(Client requested protocol \\S+? is not enabled or supported in server context" +
- "|The client supported protocol versions \\[.+?\\] are not accepted by server preferences \\[.+?\\])"),
+ "|The client supported protocol versions \\[.+?\\] are not accepted by server preferences \\[.+?\\]" +
+ "|No appropriate protocol \\(protocol is disabled or cipher suites are inappropriate\\))"),
INCOMPATIBLE_CIPHERS(
MetricDefinitions.SSL_HANDSHAKE_FAILURE_INCOMPATIBLE_CIPHERS,
"INCOMPATIBLE_CLIENT_CIPHER_SUITES",
diff --git a/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/server/jetty/HttpServerTest.java b/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/server/jetty/HttpServerTest.java
index f61939de90b..8ac1e5c1f29 100644
--- a/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/server/jetty/HttpServerTest.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/server/jetty/HttpServerTest.java
@@ -44,7 +44,6 @@ import org.eclipse.jetty.client.ProxyProtocolClientConnectionFactory.V2;
import org.eclipse.jetty.client.api.ContentResponse;
import org.eclipse.jetty.server.handler.AbstractHandlerContainer;
import org.eclipse.jetty.util.ssl.SslContextFactory;
-import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
@@ -654,7 +653,6 @@ public class HttpServerTest {
}
@Test
- @Ignore
public void requireThatMetricIsIncrementedWhenClientUsesIncompatibleTlsVersion() throws IOException {
Path privateKeyFile = tmpFolder.newFile().toPath();
Path certificateFile = tmpFolder.newFile().toPath();