diff options
author | Andreas Eriksen <andreer@yahooinc.com> | 2023-04-13 11:52:48 +0200 |
---|---|---|
committer | Andreas Eriksen <andreer@yahooinc.com> | 2023-04-13 12:11:03 +0200 |
commit | ea9e4cb6145bf9c8a6911e2db82bb02fbb66dc08 (patch) | |
tree | 0fdc12773fbe431fd946d7611e2c08986578fdeb | |
parent | 4cbd6f0dc2b73c9c728a9c0044604483cdf331d0 (diff) |
more generic log message (still friendly enough?)
2 files changed, 3 insertions, 4 deletions
diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/certificates/EndpointCertificateValidatorImpl.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/certificates/EndpointCertificateValidatorImpl.java index dbb207d6607..cff61f1a50a 100644 --- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/certificates/EndpointCertificateValidatorImpl.java +++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/certificates/EndpointCertificateValidatorImpl.java @@ -69,11 +69,10 @@ public class EndpointCertificateValidatorImpl implements EndpointCertificateVali // Normally because the cert is in the process of being provisioned - this will cause a retry in InternalStepRunner throw new EndpointCertificateException(EndpointCertificateException.Type.CERT_NOT_AVAILABLE, "Certificate not found in secret store"); } catch (EndpointCertificateException e) { - if (e.type().equals(EndpointCertificateException.Type.CERT_NOT_AVAILABLE)) { - throw e; // such failures are normal and will be retried, it takes some time to show up in the secret store - } else { + if (!e.type().equals(EndpointCertificateException.Type.CERT_NOT_AVAILABLE)) { // such failures are normal and will be retried, it takes some time to show up in the secret store log.log(Level.WARNING, "Certificate validation failure for " + serializedInstanceId, e); } + throw e; } catch (Exception e) { log.log(Level.WARNING, "Certificate validation failure for " + serializedInstanceId, e); throw new EndpointCertificateException(EndpointCertificateException.Type.VERIFICATION_FAILURE, "Certificate validation failure for app " + serializedInstanceId, e); diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java index 451f5555eb2..7b1a1e879d6 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java @@ -279,7 +279,7 @@ public class InternalStepRunner implements StepRunner { switch (e.type()) { case CERT_NOT_AVAILABLE: // Same as CERTIFICATE_NOT_READY above, only from the controller - logger.log("Creating a CA signed certificate for the application. " + + logger.log("Retrieving CA signed certificate for the application. " + "This may take up to " + timeouts.endpointCertificate() + " on first deployment."); if (startTime.plus(timeouts.endpointCertificate()).isBefore(controller.clock().instant())) { logger.log(WARNING, "CA signed certificate for app not available within " + |