aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2018-01-05 12:45:19 +0100
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2018-01-05 12:45:19 +0100
commitfff9c4a16c7d57f4535b08980d778785bf9ef6fe (patch)
tree61f4b186d274a86c75dd700be8b5283febdad85d
parent7a1e1667753c77a0214a1e0d475cf4bac0627f3b (diff)
Removed DELETE jobs
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiHandler.java9
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiTest.java7
2 files changed, 1 insertions, 15 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiHandler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiHandler.java
index c60c66a492b..56f84189092 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiHandler.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiHandler.java
@@ -59,7 +59,6 @@ public class ScrewdriverApiHandler extends LoggingRequestHandler {
switch (method) {
case GET: return get(request);
case POST: return post(request);
- case DELETE: return delete(request);
default: return ErrorResponse.methodNotAllowed("Method '" + method + "' is unsupported");
}
} catch (IllegalArgumentException|IllegalStateException e) {
@@ -92,14 +91,6 @@ public class ScrewdriverApiHandler extends LoggingRequestHandler {
return notFound(request);
}
- private HttpResponse delete(HttpRequest request) {
- Path path = new Path(request.getUri().getPath());
- if (path.matches("/screwdriver/v1/jobsToRun")) {
- return buildJobs(controller.applications().deploymentTrigger().deploymentQueue().takeJobsToRun());
- }
- return notFound(request);
- }
-
private HttpResponse trigger(HttpRequest request, String tenantName, String applicationName) {
JobType jobType = Optional.of(asString(request.getData()))
.filter(s -> !s.isEmpty())
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiTest.java
index 7a9973f2742..46082f10b74 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/screwdriver/ScrewdriverApiTest.java
@@ -100,15 +100,10 @@ public class ScrewdriverApiTest extends ControllerContainerTest {
assertEquals("Response contains only two items", 2, SlimeUtils.jsonToSlime(response.getBody()).get().entries());
// Check that GET didn't affect the enqueued jobs.
- response = container.handleRequest(new Request("http://localhost:8080/screwdriver/v1/jobsToRun", "", Request.Method.DELETE));
+ response = container.handleRequest(new Request("http://localhost:8080/screwdriver/v1/jobsToRun", "", Request.Method.GET));
assertTrue("Response contains system-test", response.getBodyAsString().contains(JobType.systemTest.jobName()));
assertTrue("Response contains staging-test", response.getBodyAsString().contains(JobType.stagingTest.jobName()));
assertEquals("Response contains only two items", 2, SlimeUtils.jsonToSlime(response.getBody()).get().entries());
-
- Thread.sleep(50);
- // Check that the *first* DELETE has removed the enqueued jobs.
- assertResponse(new Request("http://localhost:8080/screwdriver/v1/jobsToRun", "", Request.Method.DELETE),
- 200, "[]");
}
@Test