aboutsummaryrefslogtreecommitdiffstats
path: root/client/go/internal/cli/cmd/log.go
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2024-06-18 15:34:30 +0200
committerGitHub <noreply@github.com>2024-06-18 15:34:30 +0200
commit21994d15f12d5632a8ac2169821fa1950ac67215 (patch)
tree35a7a474bd5410b1d7c573ddf97acb33d4426565 /client/go/internal/cli/cmd/log.go
parent07f6c270db5b51300144c4f981d72e3cd17508d3 (diff)
parentf924368069d7edfca29455acd9695cd5caa2105a (diff)
Merge pull request #31602 from vespa-engine/mpolden/vespa-log-local
Support non-cloud target in vespa log
Diffstat (limited to 'client/go/internal/cli/cmd/log.go')
-rw-r--r--client/go/internal/cli/cmd/log.go10
1 files changed, 8 insertions, 2 deletions
diff --git a/client/go/internal/cli/cmd/log.go b/client/go/internal/cli/cmd/log.go
index 77ef7f68130..53b7079f428 100644
--- a/client/go/internal/cli/cmd/log.go
+++ b/client/go/internal/cli/cmd/log.go
@@ -6,6 +6,7 @@ import (
"time"
"github.com/spf13/cobra"
+ "github.com/vespa-engine/vespa/client/go/internal/version"
"github.com/vespa-engine/vespa/client/go/internal/vespa"
)
@@ -34,7 +35,7 @@ $ vespa log --follow`,
SilenceUsage: true,
Args: cobra.MaximumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
- target, err := cli.target(targetOptions{logLevel: levelArg, supportedType: cloudTargetOnly})
+ target, err := cli.target(targetOptions{logLevel: levelArg})
if err != nil {
return err
}
@@ -58,7 +59,12 @@ $ vespa log --follow`,
options.To = to
}
if err := target.PrintLog(options); err != nil {
- return fmt.Errorf("could not retrieve logs: %w", err)
+ versionWithLogContainer := version.MustParse("8.359.0")
+ var hints []string
+ if err := target.CompatibleWith(versionWithLogContainer); err != nil {
+ hints = []string{fmt.Sprintf("This command requires a newer version of the Vespa platform: %s", err)}
+ }
+ return errHint(fmt.Errorf("could not retrieve logs: %w", err), hints...)
}
return nil
},