diff options
author | Martin Polden <mpolden@mpolden.no> | 2024-06-18 15:33:53 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-18 15:33:53 +0200 |
commit | 07f6c270db5b51300144c4f981d72e3cd17508d3 (patch) | |
tree | 5232b4e5577465dc47ec4546ade53dea12b2c898 /client/go/internal | |
parent | 4fc8419743129d36e227f456de619c4637fe8642 (diff) | |
parent | 368904d0f1acbf20a546886d8e6bd5f72e38d42c (diff) |
Merge pull request #31603 from vespa-engine/mpolden/skip-discovery
Skip cluster discovery and waiting when using a custom target
Diffstat (limited to 'client/go/internal')
-rw-r--r-- | client/go/internal/cli/cmd/deploy.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/client/go/internal/cli/cmd/deploy.go b/client/go/internal/cli/cmd/deploy.go index 4792088a915..d3bda1089a7 100644 --- a/client/go/internal/cli/cmd/deploy.go +++ b/client/go/internal/cli/cmd/deploy.go @@ -185,8 +185,10 @@ func waitForVespaReady(target vespa.Target, sessionOrRunID int64, waiter *Waiter if _, err := waiter.Deployment(target, sessionOrRunID); err != nil { return err } - // Wait for healthy services - if hasTimeout { + // Wait for healthy services where we expect them to be reachable (cloud and local). When using a custom target, + // we do not wait for services as there is no guarantee that they are reachable from the machine executing + // deploy. + if hasTimeout && (target.IsCloud() || target.Type() == vespa.TargetLocal) { _, err := waiter.Services(target) return err } |