aboutsummaryrefslogtreecommitdiffstats
path: root/config-model/src/main/java/com/yahoo/vespa/model/application
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2021-12-09 08:49:15 +0100
committerGitHub <noreply@github.com>2021-12-09 08:49:15 +0100
commit0a12fa19c2462234579f24fc52e88476b39a4b70 (patch)
tree53c49db05ee5769cd179beea73799e6c5010c524 /config-model/src/main/java/com/yahoo/vespa/model/application
parent2853733d3227818dd83e006e63a3c915679a7b53 (diff)
parent3a578f23ccbb8f2e20d7b8509b9699ee2962c0c1 (diff)
Merge pull request #20418 from vespa-engine/bratseth/apply-policies-to-limits-take-2
Bratseth/apply policies to limits take 2
Diffstat (limited to 'config-model/src/main/java/com/yahoo/vespa/model/application')
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/application/validation/QuotaValidator.java2
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/ClusterSizeReductionValidator.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/QuotaValidator.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/QuotaValidator.java
index 10d97cbb58c..d1dc2b84c8a 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/QuotaValidator.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/QuotaValidator.java
@@ -39,7 +39,7 @@ public class QuotaValidator extends Validator {
var maxSpend = model.allClusters().stream()
.filter(id -> !adminClusterIds(model).contains(id))
.map(id -> model.provisioned().all().getOrDefault(id, zeroCapacity))
- .mapToDouble(c -> c.maxResources().cost())
+ .mapToDouble(c -> c.maxResources().cost()) // TODO: This may be unspecified -> 0
.sum();
var actualSpend = model.allocatedHosts().getHosts().stream()
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/ClusterSizeReductionValidator.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/ClusterSizeReductionValidator.java
index 25a570e44a2..14fb903a547 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/ClusterSizeReductionValidator.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/ClusterSizeReductionValidator.java
@@ -41,7 +41,7 @@ public class ClusterSizeReductionValidator implements ChangeValidator {
int currentSize = current.minResources().nodes();
int nextSize = next.minResources().nodes();
// don't allow more than 50% reduction, but always allow to reduce size with 1
- if ( nextSize < ((double)currentSize) * 0.5 && nextSize != currentSize - 1)
+ if ( nextSize < currentSize * 0.5 && nextSize != currentSize - 1)
overrides.invalid(ValidationId.clusterSizeReduction,
"Size reduction in '" + clusterId.value() + "' is too large: " +
"New min size must be at least 50% of the current min size. " +