aboutsummaryrefslogtreecommitdiffstats
path: root/config-model
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-10-06 20:36:05 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2022-10-06 20:36:05 +0200
commit54fae00cefe5e3483461a472d49ee4310b023722 (patch)
treea03a6e5b101cc9d94d8a132e14caa6b09be3801b /config-model
parent08302fcfa246914e2b58b29b5c56f9ba8ae3cb96 (diff)
GC max-concurrent-merges-per-node
Diffstat (limited to 'config-model')
-rw-r--r--config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java6
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/StorServerProducer.java1
-rw-r--r--config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java6
3 files changed, 3 insertions, 10 deletions
diff --git a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
index 2520dda2ed0..fa14bdf9b5b 100644
--- a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
+++ b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
@@ -55,7 +55,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea
private int maxActivationInhibitedOutOfSyncGroups = 0;
private List<TenantSecretStore> tenantSecretStores = Collections.emptyList();
private String jvmOmitStackTraceInFastThrowOption;
- private int maxConcurrentMergesPerNode = 16;
private int maxMergeQueueSize = 100;
private boolean allowDisableMtls = true;
private List<X509Certificate> operatorCertificates = Collections.emptyList();
@@ -111,7 +110,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea
@Override public String jvmOmitStackTraceInFastThrowOption(ClusterSpec.Type type) { return jvmOmitStackTraceInFastThrowOption; }
@Override public boolean allowDisableMtls() { return allowDisableMtls; }
@Override public List<X509Certificate> operatorCertificates() { return operatorCertificates; }
- @Override public int maxConcurrentMergesPerNode() { return maxConcurrentMergesPerNode; }
@Override public int maxMergeQueueSize() { return maxMergeQueueSize; }
@Override public double resourceLimitDisk() { return resourceLimitDisk; }
@Override public double resourceLimitMemory() { return resourceLimitMemory; }
@@ -206,10 +204,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea
return this;
}
- public TestProperties setMaxConcurrentMergesPerNode(int maxConcurrentMergesPerNode) {
- this.maxConcurrentMergesPerNode = maxConcurrentMergesPerNode;
- return this;
- }
public TestProperties setMaxMergeQueueSize(int maxMergeQueueSize) {
this.maxMergeQueueSize = maxMergeQueueSize;
return this;
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/StorServerProducer.java b/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/StorServerProducer.java
index 86785ea20d2..555b38e20ba 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/StorServerProducer.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/StorServerProducer.java
@@ -45,7 +45,6 @@ public class StorServerProducer implements StorServerConfig.Producer {
StorServerProducer(String clusterName, ModelContext.FeatureFlags featureFlags) {
this.clusterName = clusterName;
- maxMergesPerNode = featureFlags.maxConcurrentMergesPerNode();
queueSize = featureFlags.maxMergeQueueSize();
}
diff --git a/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java b/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java
index 48cee3fd397..8f9941820d6 100644
--- a/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java
+++ b/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java
@@ -121,7 +121,7 @@ public class StorageClusterTest {
"<tuning>",
" <merges max-per-node=\"1K\" max-queue-size=\"10K\"/>",
"</tuning>")),
- new TestProperties().setMaxMergeQueueSize(1919).setMaxConcurrentMergesPerNode(37)
+ new TestProperties().setMaxMergeQueueSize(1919)
).getConfig(builder);
StorServerConfig config = new StorServerConfig(builder);
@@ -174,8 +174,8 @@ public class StorageClusterTest {
@Test
void testMergeFeatureFlags() {
- var config = configFromProperties(new TestProperties().setMaxMergeQueueSize(1919).setMaxConcurrentMergesPerNode(37));
- assertEquals(37, config.max_merges_per_node());
+ var config = configFromProperties(new TestProperties().setMaxMergeQueueSize(1919));
+ assertEquals(16, config.max_merges_per_node());
assertEquals(1919, config.max_merge_queue_size());
}