diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-03 00:35:28 +0100 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-05 11:31:59 +0000 |
commit | cb715c88940e51867c3fa56c71dce52804049cea (patch) | |
tree | 7e40a6cdf2ee78973c41731f59ea244f1a5b7243 /config-model | |
parent | 88798d4e0191eecb4aac41091d643ce5b30ea6d4 (diff) |
GC traces of enable_multibit_split_optimalization
Diffstat (limited to 'config-model')
6 files changed, 0 insertions, 28 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/DummyPersistence.java b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/DummyPersistence.java index 61dd4380f1b..f3f08defe6e 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/DummyPersistence.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/DummyPersistence.java @@ -26,11 +26,6 @@ public class DummyPersistence extends PersistenceEngine { } @Override - public boolean enableMultiLevelSplitting() { - return true; - } - - @Override public ContentCluster.DistributionMode getDefaultDistributionMode() { return ContentCluster.DistributionMode.LOOSE; } diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/PersistenceEngine.java b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/PersistenceEngine.java index e80577184be..633689a7dca 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/PersistenceEngine.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/PersistenceEngine.java @@ -23,14 +23,6 @@ public abstract class PersistenceEngine extends TreeConfigProducer<AnyConfigProd PersistenceEngine create(DeployState deployState, StorageNode storageNode, StorageGroup parentGroup, ModelElement storageNodeElement); - /** - * Multi level splitting can increase split performance a lot where documents have been - * co-localized, for backends where retrieving document identifiers contained in bucket - * is cheap. Backends where split is cheaper than fetching document identifiers will - * not want to enable multi level splitting. - */ - boolean enableMultiLevelSplitting(); - ContentCluster.DistributionMode getDefaultDistributionMode(); } diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/ProtonEngine.java b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/ProtonEngine.java index 860f2534736..98f4ebd7ac9 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/engines/ProtonEngine.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/engines/ProtonEngine.java @@ -27,11 +27,6 @@ public class ProtonEngine { } @Override - public boolean enableMultiLevelSplitting() { - return false; - } - - @Override public ContentCluster.DistributionMode getDefaultDistributionMode() { return ContentCluster.DistributionMode.LOOSE; } diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/FileStorProducer.java b/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/FileStorProducer.java index 4f283d6d9c3..6fd917c393d 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/FileStorProducer.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/storagecluster/FileStorProducer.java @@ -70,7 +70,6 @@ public class FileStorProducer implements StorFilestorConfig.Producer { if (numThreads != null) { builder.num_threads(numThreads); } - builder.enable_multibit_split_optimalization(cluster.getPersistence().enableMultiLevelSplitting()); builder.num_response_threads(responseNumThreads); builder.response_sequencer_type(responseSequencerType); builder.use_async_message_handling_on_schedule(useAsyncMessageHandlingOnSchedule); diff --git a/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java b/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java index de962ff1924..1ba5bebea7e 100644 --- a/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java +++ b/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java @@ -447,13 +447,6 @@ public class ContentClusterTest extends ContentBaseTest { StorDistributormanagerConfig config = new StorDistributormanagerConfig(builder); assertFalse(config.inlinebucketsplitting()); } - - { - StorFilestorConfig.Builder builder = new StorFilestorConfig.Builder(); - model.getConfig(builder, "bar/storage/0"); - StorFilestorConfig config = new StorFilestorConfig(builder); - assertFalse(config.enable_multibit_split_optimalization()); - } } @Test diff --git a/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java b/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java index 574f5b04075..0dd03d258b9 100644 --- a/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java +++ b/config-model/src/test/java/com/yahoo/vespa/model/content/StorageClusterTest.java @@ -231,7 +231,6 @@ public class StorageClusterTest { var config = filestorConfigFromProducer(stc); assertEquals(7, config.num_threads()); - assertFalse(config.enable_multibit_split_optimalization()); assertEquals(2, config.num_response_threads()); } { @@ -275,7 +274,6 @@ public class StorageClusterTest { var config = filestorConfigFromProducer(stc); assertEquals(4, config.num_threads()); - assertFalse(config.enable_multibit_split_optimalization()); } { assertEquals(1, stc.getChildren().size()); |