Merge pull request #15577 from vespa-engine/revert-15575-bratseth/apply-on-restart-take-9

Revert "Bratseth/apply on restart take 9"

1 files changed, 10 insertions, 24 deletions

diff --git a/config/src/main/java/com/yahoo/config/subscription/impl/ConfigSubscription.java b/config/src/main/java/com/yahoo/config/subscription/impl/ConfigSubscription.java
index 15f6395c417..3bf6093e872 100644
--- a/config/src/main/java/com/yahoo/config/subscription/impl/ConfigSubscription.java
+++ b/config/src/main/java/com/yahoo/config/subscription/impl/ConfigSubscription.java
@@ -40,28 +40,21 @@ public abstract class ConfigSubscription<T extends ConfigInstance> {
         private final T config;
         private final Long generation;
         private final boolean internalRedeploy;
-        private final boolean applyOnRestart;
-
-        private ConfigState(boolean generationChanged,
-                            Long generation,
-                            boolean internalRedeploy,
-                            boolean applyOnRestart,
-                            boolean configChanged,
-                            T config) {
+
+        private ConfigState(boolean generationChanged, Long generation, boolean internalRedeploy, boolean configChanged, T config) {
             this.generationChanged = generationChanged;
             this.generation = generation;
             this.internalRedeploy = internalRedeploy;
-            this.applyOnRestart = applyOnRestart;
             this.configChanged = configChanged;
             this.config = config;
         }
 
         private ConfigState(Long generation, T config) {
-            this(false, generation, false, false, false, config);
+            this(false, generation, false, false, config);
         }
 
         private ConfigState() {
-            this(false, 0L, false, false, false, null);
+            this(false, 0L, false, false, null);
         }
 
         private ConfigState<T> createUnchanged() { return new ConfigState<>(generation, config); }
@@ -75,8 +68,6 @@ public abstract class ConfigSubscription<T extends ConfigInstance> {
          */
         public boolean isInternalRedeploy() { return internalRedeploy; }
 
-        public boolean applyOnRestart() { return applyOnRestart; }
-
         public T getConfig() { return config; }
 
     }
@@ -190,34 +181,29 @@ public abstract class ConfigSubscription<T extends ConfigInstance> {
         return !prev.getGeneration().equals(requiredGen) || prev.isConfigChanged();
     }
 
-    void setConfig(Long generation, boolean internalRedeploy, boolean applyOnRestart, T config) {
-        this.config.set(new ConfigState<>(true, generation, internalRedeploy, applyOnRestart, true, config));
+    void setConfig(Long generation, boolean internalRedeploy, T config) {
+        this.config.set(new ConfigState<>(true, generation, internalRedeploy, true, config));
     }
 
     /** Used by {@link FileConfigSubscription} and {@link ConfigSetSubscription} */
     protected void setConfigIncGen(T config) {
         ConfigState<T> prev = this.config.get();
-        this.config.set(new ConfigState<>(true, prev.getGeneration() + 1, prev.isInternalRedeploy(), prev.applyOnRestart(), true, config));
+        this.config.set(new ConfigState<>(true, prev.getGeneration() + 1, prev.isInternalRedeploy(), true, config));
     }
 
     protected void setConfigIfChanged(T config) {
         ConfigState<T> prev = this.config.get();
-        this.config.set(new ConfigState<>(true, prev.getGeneration(), prev.isInternalRedeploy(), prev.applyOnRestart(), !config.equals(prev.getConfig()), config));
+        this.config.set(new ConfigState<>(true, prev.getGeneration(), prev.isInternalRedeploy(), !config.equals(prev.getConfig()), config));
     }
 
     void setGeneration(Long generation) {
         ConfigState<T> prev = config.get();
-        this.config.set(new ConfigState<>(true, generation, prev.isInternalRedeploy(), prev.applyOnRestart(), prev.isConfigChanged(), prev.getConfig()));
+        this.config.set(new ConfigState<>(true, generation, prev.isInternalRedeploy(), prev.isConfigChanged(), prev.getConfig()));
     }
 
     void setInternalRedeploy(boolean internalRedeploy) {
         ConfigState<T> prev = config.get();
-        this.config.set(new ConfigState<>(prev.isGenerationChanged(), prev.getGeneration(), internalRedeploy, prev.applyOnRestart(), prev.isConfigChanged(), prev.getConfig()));
-    }
-
-    void setApplyOnRestart(boolean applyOnRestart) {
-        ConfigState<T> prev = config.get();
-        this.config.set(new ConfigState<>(prev.isGenerationChanged(), prev.getGeneration(), prev.isInternalRedeploy(), applyOnRestart, prev.isConfigChanged(), prev.getConfig()));
+        this.config.set(new ConfigState<>(prev.isGenerationChanged(), prev.getGeneration(), internalRedeploy, prev.isConfigChanged(), prev.getConfig()));
     }
 
     /**