diff options
author | Harald Musum <musum@yahooinc.com> | 2021-09-09 17:25:59 +0200 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2021-09-09 17:25:59 +0200 |
commit | 27eb10e2974ca518468f1649e0d29fc3ec8febe9 (patch) | |
tree | e3364ad08706015ad74ac13f99c706ff5af689d5 /config/src/test | |
parent | 979cb96cdeb6739d7ea769c60a04bac174619be1 (diff) |
Stop validating length of checksums
Not needed, and the way we calculated hex string from a long
did not always return 16 characters, so fixes that issue.
Also log validation failures as warnings
Diffstat (limited to 'config/src/test')
-rw-r--r-- | config/src/test/java/com/yahoo/vespa/config/RequestValidationTest.java | 1 | ||||
-rw-r--r-- | config/src/test/java/com/yahoo/vespa/config/protocol/JRTConfigRequestV3Test.java | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/config/src/test/java/com/yahoo/vespa/config/RequestValidationTest.java b/config/src/test/java/com/yahoo/vespa/config/RequestValidationTest.java index 2b7fd9c350b..8e0c0d1671e 100644 --- a/config/src/test/java/com/yahoo/vespa/config/RequestValidationTest.java +++ b/config/src/test/java/com/yahoo/vespa/config/RequestValidationTest.java @@ -26,7 +26,6 @@ public class RequestValidationTest { assertTrue(new PayloadChecksum("e8f0c01c7c3dcb8d3f62d7ff777fce6b", MD5).valid()); assertTrue(new PayloadChecksum("e8f0c01c7c3dcb8d3f62d7ff777fce6B", MD5).valid()); assertTrue(new PayloadChecksum("e8f0c01c7c3dcb8d", XXHASH64).valid()); - assertFalse(new PayloadChecksum("aaaaaaaaaaaaaaaaaa", MD5).valid()); assertFalse(new PayloadChecksum("-8f0c01c7c3dcb8d3f62d7ff777fce6b", MD5).valid()); } diff --git a/config/src/test/java/com/yahoo/vespa/config/protocol/JRTConfigRequestV3Test.java b/config/src/test/java/com/yahoo/vespa/config/protocol/JRTConfigRequestV3Test.java index 5a3110c9221..0a4fc3da6cb 100644 --- a/config/src/test/java/com/yahoo/vespa/config/protocol/JRTConfigRequestV3Test.java +++ b/config/src/test/java/com/yahoo/vespa/config/protocol/JRTConfigRequestV3Test.java @@ -237,7 +237,7 @@ public class JRTConfigRequestV3Test { assertTrue(serverReq.validateParameters()); assertValidationFail(createReq("35#$#!$@#", defNamespace, hostname, configId, payloadChecksums, currentGeneration, timeout, trace)); assertValidationFail(createReq(defName, "abcd.o#$*(!&$", hostname, configId, payloadChecksums, currentGeneration, timeout, trace)); - assertValidationFail(createReq(defName, defNamespace, hostname, configId, PayloadChecksums.from("abcd", "1234"), currentGeneration, timeout, trace)); + assertValidationFail(createReq(defName, defNamespace, hostname, configId, PayloadChecksums.from("opnq", "1234"), currentGeneration, timeout, trace)); assertValidationFail(createReq(defName, defNamespace, hostname, configId, payloadChecksums, -34, timeout, trace)); assertValidationFail(createReq(defName, defNamespace, hostname, configId, payloadChecksums, currentGeneration, -23, trace)); assertValidationFail(createReq(defName, defNamespace, "", configId, payloadChecksums, currentGeneration, timeout, trace)); |