aboutsummaryrefslogtreecommitdiffstats
path: root/configgen
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2020-11-27 15:25:28 +0100
committerGitHub <noreply@github.com>2020-11-27 15:25:28 +0100
commit3c0d5e11e703cecc815f1afc77829a9e227db1a4 (patch)
treed1c6e1fc6efa5b7ab061937f1d89dc8ae9d6cab9 /configgen
parent7a1a70055770a82bf42bff668abaf011af3f6e55 (diff)
Revert "Bratseth/apply on restart take 3"
Diffstat (limited to 'configgen')
-rw-r--r--configgen/src/main/java/com/yahoo/config/codegen/BuilderGenerator.java42
-rw-r--r--configgen/src/test/resources/allfeatures.reference14
2 files changed, 18 insertions, 38 deletions
diff --git a/configgen/src/main/java/com/yahoo/config/codegen/BuilderGenerator.java b/configgen/src/main/java/com/yahoo/config/codegen/BuilderGenerator.java
index 2ebe7ad03bf..b3c4d0c5ff8 100644
--- a/configgen/src/main/java/com/yahoo/config/codegen/BuilderGenerator.java
+++ b/configgen/src/main/java/com/yahoo/config/codegen/BuilderGenerator.java
@@ -44,7 +44,7 @@ public class BuilderGenerator {
}
private static String getSpecialRootBuilderCode(InnerCNode node) {
- return (node.getParent() == null) ? "\n" + getRootDeclarations() + "\n" : "";
+ return (node.getParent() == null) ? "\n" + getDispatchCode() + "\n" : "";
}
private static String getBuildMethod(InnerCNode node) {
@@ -53,36 +53,26 @@ public class BuilderGenerator {
"}\n";
}
- private static String getRootDeclarations() {
+ private static String getDispatchCode() {
// Use full path to @Override, as users are free to define an inner node called
// 'override'. (summarymap.def does)
// The generated inner 'Override' class would otherwise be mistaken for the
// annotation.
- return "private boolean _applyOnRestart = false;\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final boolean dispatchGetConfig(ConfigInstance.Producer producer) {\n" +
- " if (producer instanceof Producer) {\n" +
- " ((Producer)producer).getConfig(this);\n" +
- " return true;\n" +
+ return "@java.lang.Override\n" + //
+ "public final boolean dispatchGetConfig(ConfigInstance.Producer producer) {\n" + //
+ " if (producer instanceof Producer) {\n" + //
+ " ((Producer)producer).getConfig(this);\n" + //
+ " return true;\n" + //
" }\n" + //
- " return false;\n" +
- "}\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final String getDefMd5() { return CONFIG_DEF_MD5; }\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final String getDefName() { return CONFIG_DEF_NAME; }\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final String getDefNamespace() { return CONFIG_DEF_NAMESPACE; }\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final boolean getApplyOnRestart() { return _applyOnRestart; }\n" +
- "\n" +
- "@java.lang.Override\n" +
- "public final void setApplyOnRestart(boolean applyOnRestart) { _applyOnRestart = applyOnRestart; }";
+ " return false;\n" + //
+ "}\n" + //
+ "\n" + //
+ "@java.lang.Override\n" + //
+ "public final String getDefMd5() { return CONFIG_DEF_MD5; }\n" + //
+ "@java.lang.Override\n" + //
+ "public final String getDefName() { return CONFIG_DEF_NAME; }\n" + //
+ "@java.lang.Override\n" + //
+ "public final String getDefNamespace() { return CONFIG_DEF_NAMESPACE; }";
}
private static String getUninitializedScalars(InnerCNode node) {
diff --git a/configgen/src/test/resources/allfeatures.reference b/configgen/src/test/resources/allfeatures.reference
index 2008bbf6b52..b84f01f380b 100644
--- a/configgen/src/test/resources/allfeatures.reference
+++ b/configgen/src/test/resources/allfeatures.reference
@@ -601,8 +601,6 @@ public final class AllfeaturesConfig extends ConfigInstance {
return this;
}
- private boolean _applyOnRestart = false;
-
@java.lang.Override
public final boolean dispatchGetConfig(ConfigInstance.Producer producer) {
if (producer instanceof Producer) {
@@ -613,20 +611,12 @@ public final class AllfeaturesConfig extends ConfigInstance {
}
@java.lang.Override
- public final String getDefMd5() { return CONFIG_DEF_MD5; }
-
+ public final String getDefMd5() { return CONFIG_DEF_MD5; }
@java.lang.Override
- public final String getDefName() { return CONFIG_DEF_NAME; }
-
+ public final String getDefName() { return CONFIG_DEF_NAME; }
@java.lang.Override
public final String getDefNamespace() { return CONFIG_DEF_NAMESPACE; }
- @java.lang.Override
- public final boolean getApplyOnRestart() { return _applyOnRestart; }
-
- @java.lang.Override
- public final void setApplyOnRestart(boolean applyOnRestart) { _applyOnRestart = applyOnRestart; }
-
public AllfeaturesConfig build() {
return new AllfeaturesConfig(this);
}