aboutsummaryrefslogtreecommitdiffstats
path: root/configserver-flags
diff options
context:
space:
mode:
authorBjørn Christian Seime <bjorncs@verizonmedia.com>2020-12-02 16:44:22 +0100
committerBjørn Christian Seime <bjorncs@verizonmedia.com>2020-12-02 16:44:22 +0100
commit63ad89e56c6e85bc5662ed43c5d423bc4552ff5a (patch)
treea462ff04464dfd94f8791ad52309b62d20ebda58 /configserver-flags
parentd5468c02566bff2aaf3dc45d849393aa77af45bc (diff)
Flag definition has changed
Diffstat (limited to 'configserver-flags')
-rw-r--r--configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/ConfigServerFlagSourceTest.java3
-rw-r--r--configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/http/FlagsHandlerTest.java7
2 files changed, 6 insertions, 4 deletions
diff --git a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/ConfigServerFlagSourceTest.java b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/ConfigServerFlagSourceTest.java
index 56762e7bae5..531ab98cafb 100644
--- a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/ConfigServerFlagSourceTest.java
+++ b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/ConfigServerFlagSourceTest.java
@@ -17,6 +17,7 @@ import java.nio.charset.StandardCharsets;
import java.nio.file.FileSystem;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.util.List;
import java.util.Optional;
import static org.junit.Assert.assertFalse;
@@ -52,7 +53,7 @@ public class ConfigServerFlagSourceTest {
private void initialize() {
flagSource = new ConfigServerFlagSource(fileSystem, flagsDb);
- flag = Flags.defineFeatureFlag(flagId.toString(), false, "", "").bindTo(flagSource);
+ flag = Flags.defineFeatureFlag(flagId.toString(), false, List.of("joe"), "2010-01-01", "2030-01-01", "", "").bindTo(flagSource);
}
@Test
diff --git a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/http/FlagsHandlerTest.java b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/http/FlagsHandlerTest.java
index cbd37c8a5cf..995701f14d7 100644
--- a/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/http/FlagsHandlerTest.java
+++ b/configserver-flags/src/test/java/com/yahoo/vespa/configserver/flags/http/FlagsHandlerTest.java
@@ -12,6 +12,7 @@ import com.yahoo.vespa.flags.FetchVector;
import com.yahoo.vespa.flags.FlagId;
import com.yahoo.vespa.flags.Flags;
import com.yahoo.vespa.flags.UnboundBooleanFlag;
+import com.yahoo.vespa.jdk8compat.List;
import com.yahoo.yolean.Exceptions;
import org.junit.Test;
@@ -32,9 +33,9 @@ import static org.junit.Assert.assertEquals;
*/
public class FlagsHandlerTest {
private static final UnboundBooleanFlag FLAG1 = Flags.defineFeatureFlag(
- "id1", false, "desc1", "mod1");
+ "id1", false, List.of("joe"), "2010-01-01", "2030-01-01", "desc1", "mod1");
private static final UnboundBooleanFlag FLAG2 = Flags.defineFeatureFlag(
- "id2", true, "desc2", "mod2",
+ "id2", true, List.of("joe"), "2010-01-01", "2030-01-01", "desc2", "mod2",
FetchVector.Dimension.HOSTNAME, FetchVector.Dimension.APPLICATION_ID);
private static final String FLAGS_V1_URL = "https://foo.com:4443/flags/v1";
@@ -57,7 +58,7 @@ public class FlagsHandlerTest {
public void testDefined() {
try (Flags.Replacer replacer = Flags.clearFlagsForTesting()) {
fixUnusedWarning(replacer);
- Flags.defineFeatureFlag("id", false, "desc", "mod", FetchVector.Dimension.HOSTNAME);
+ Flags.defineFeatureFlag("id", false, List.of("joe"), "2010-01-01", "2030-01-01", "desc", "mod", FetchVector.Dimension.HOSTNAME);
verifySuccessfulRequest(Method.GET, "/defined", "",
"{\"id\":{\"description\":\"desc\",\"modification-effect\":\"mod\",\"dimensions\":[\"hostname\"]}}");