aboutsummaryrefslogtreecommitdiffstats
path: root/configserver
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2022-01-17 12:49:31 +0100
committerHarald Musum <musum@yahooinc.com>2022-01-17 12:49:31 +0100
commit180c3a37d00569df83d32cf1ac571e3ba3c9224f (patch)
tree8c2331b5d2b49dcdc7a2c2274570fe77bf42ecd9 /configserver
parent1fb4af9551cfdec71e4282ce953e53817cd71074 (diff)
Add TODO on how to handle restartOnDeploy for container clusters
Diffstat (limited to 'configserver')
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/deploy/Deployment.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/Deployment.java b/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/Deployment.java
index 1b9ab42a327..2a40c0de45b 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/Deployment.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/Deployment.java
@@ -186,6 +186,9 @@ public class Deployment implements com.yahoo.config.provision.Deployment {
Application app = applicationRepository.getActiveApplication(applicationId);
+ // TODO: Don't wait for config convergence if restartOnDeploy is true for one o more container clusters
+ // (ideally wait for config convergence for all other services)
+
log.info(session.logPre() + "Wait for services to converge on new generation before restarting");
ConfigConvergenceChecker convergenceChecker = applicationRepository.configConvergenceChecker();
ServiceListResponse response = convergenceChecker.getConfigGenerationsForAllServices(app, timeout);