diff options
author | Harald Musum <musum@yahooinc.com> | 2021-11-15 09:23:35 +0100 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2021-11-15 09:23:35 +0100 |
commit | 4dc5452942aac011ac45437dba97873c05c06a6c (patch) | |
tree | 26f5d3675e9872d7c9819e241736b88d9c9a21c2 /configserver | |
parent | 5cb9b85ffb3ec2a77caaa4ee367ad6435bbf762a (diff) |
Improve file download logging a bit
Diffstat (limited to 'configserver')
-rw-r--r-- | configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java index d4d4a7fa7d3..5702a6b78cf 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java @@ -61,25 +61,24 @@ public class ApplicationPackageMaintainer extends ConfigServerMaintainer { try (var fileDownloader = createFileDownloader()) { for (var applicationId : applicationRepository.listApplications()) { - log.fine(() -> "Verifying application package for " + applicationId); + log.finest(() -> "Verifying application package for " + applicationId); Session session = applicationRepository.getActiveSession(applicationId); if (session == null) continue; // App might be deleted after call to listApplications() or not activated yet (bootstrap phase) - FileReference applicationPackage = session.getApplicationPackageReference(); - long sessionId = session.getSessionId(); - log.fine(() -> "Verifying application package file reference " + applicationPackage + " for session " + sessionId); - - if (applicationPackage != null) { + FileReference appFileReference = session.getApplicationPackageReference(); + if (appFileReference != null) { + long sessionId = session.getSessionId(); attempts++; - if (! fileReferenceExistsOnDisk(downloadDirectory, applicationPackage)) { - log.fine(() -> "Downloading missing application package for application " + applicationId + " (session " + sessionId + ")"); + if (! fileReferenceExistsOnDisk(downloadDirectory, appFileReference)) { + log.fine(() -> "Downloading application package for " + applicationId + " (session " + sessionId + ")"); - FileReferenceDownload download = new FileReferenceDownload(applicationPackage, + FileReferenceDownload download = new FileReferenceDownload(appFileReference, false, this.getClass().getSimpleName()); if (fileDownloader.getFile(download).isEmpty()) { failures++; - log.warning("Failed to download application package for application " + applicationId + " (session " + sessionId + ")"); + log.warning("Failed to download application package (" + appFileReference + ")" + + "for " + applicationId + " (session " + sessionId + ")"); continue; } } |