Revert "Remove org.json usage [run-systemtest]"

6 files changed, 191 insertions, 117 deletions

diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/CoredumpGatherer.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/CoredumpGatherer.java
index f1ef7894511..d105eaa9d98 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/CoredumpGatherer.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/CoredumpGatherer.java
@@ -1,16 +1,17 @@
 // Copyright 2019 Oath Inc. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 package com.yahoo.container.jdisc.state;
 
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.yahoo.vespa.defaults.Defaults;
+import org.json.JSONException;
+import org.json.JSONObject;
 
 import java.io.IOException;
 import java.io.UncheckedIOException;
+import java.nio.file.Files;
 import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import java.time.Instant;
+import java.util.Set;
 import java.util.stream.Stream;
 
 /**
@@ -18,17 +19,19 @@ import java.util.stream.Stream;
  */
 public class CoredumpGatherer {
 
-    private static final ObjectMapper jsonMapper = new ObjectMapper();
-
     private static final Path COREDUMP_PATH = Path.of(Defaults.getDefaults().underVespaHome("var/crash/processing"));
 
-    public static JsonNode gatherCoredumpMetrics(FileWrapper fileWrapper) {
+    public static JSONObject gatherCoredumpMetrics(FileWrapper fileWrapper) {
         int coredumps = getNumberOfCoredumps(fileWrapper);
-        ObjectNode packet = jsonMapper.createObjectNode();
-        packet.put("status_code", coredumps == 0 ? 0 : 1);
-        packet.put("status_msg", coredumps == 0 ? "OK" : String.format("Found %d coredump(s)", coredumps));
-        packet.put("timestamp", Instant.now().getEpochSecond());
-        packet.put("application", "system-coredumps-processing");
+        JSONObject packet = new JSONObject();
+
+        try {
+            packet.put("status_code", coredumps == 0 ? 0 : 1);
+            packet.put("status_msg", coredumps == 0 ? "OK" : String.format("Found %d coredump(s)", coredumps));
+            packet.put("timestamp", Instant.now().getEpochSecond());
+            packet.put("application", "system-coredumps-processing");
+
+        } catch (JSONException e) {}
         return packet;
     }
 
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
index 28f99096d84..730f7bc13cd 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
@@ -1,9 +1,8 @@
 // Copyright 2019 Oath Inc. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 package com.yahoo.container.jdisc.state;
 
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ObjectNode;
+import org.json.JSONException;
+import org.json.JSONObject;
 
 import java.io.IOException;
 import java.nio.file.Path;
@@ -14,11 +13,9 @@ import java.time.Instant;
  */
 public class HostLifeGatherer {
 
-    private static final ObjectMapper jsonMapper = new ObjectMapper();
-
     private static final Path UPTIME_PATH = Path.of("/proc");
 
-    public static JsonNode getHostLifePacket(FileWrapper fileWrapper) {
+    public static JSONObject getHostLifePacket(FileWrapper fileWrapper) {
         long upTime;
         int statusCode = 0;
         String statusMessage = "OK";
@@ -32,15 +29,19 @@ public class HostLifeGatherer {
         }
 
 
-        ObjectNode jsonObject = jsonMapper.createObjectNode();
-        jsonObject.put("status_code", statusCode);
-        jsonObject.put("status_msg", statusMessage);
-        jsonObject.put("timestamp", Instant.now().getEpochSecond());
-        jsonObject.put("application", "host_life");
-        ObjectNode metrics = jsonMapper.createObjectNode();
-        metrics.put("uptime", upTime);
-        metrics.put("alive", 1);
-        jsonObject.set("metrics", metrics);
+        JSONObject jsonObject = new JSONObject();
+        try {
+            jsonObject.put("status_code", statusCode);
+            jsonObject.put("status_msg", statusMessage);
+            jsonObject.put("timestamp", Instant.now().getEpochSecond());
+            jsonObject.put("application", "host_life");
+            JSONObject metrics = new JSONObject();
+            metrics.put("uptime", upTime);
+            metrics.put("alive", 1);
+            jsonObject.put("metrics", metrics);
+
+        } catch (JSONException e) {}
+
         return jsonObject;
     }
 
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java
new file mode 100644
index 00000000000..d22dd9d6f4b
--- /dev/null
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java
@@ -0,0 +1,87 @@
+// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.jdisc.state;
+
+import org.json.JSONException;
+import org.json.JSONObject;
+
+import java.util.Collection;
+import java.util.Map;
+
+/**
+ * A JSONObject that wraps the checked JSONException in a RuntimeException with a legible error message.
+ *
+ * @author gjoranv
+ */
+class JSONObjectWithLegibleException extends JSONObject {
+
+    @Override
+    public JSONObject put(String s, boolean b) {
+        try {
+            return super.put(s, b);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, b, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, double v) {
+        try {
+            Double guardedVal = (((Double) v).isNaN() || ((Double) v).isInfinite()) ?
+                    0.0 : v;
+            return super.put(s, guardedVal);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, v, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, int i) {
+        try {
+            return super.put(s, i);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, i, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, long l) {
+        try {
+            return super.put(s, l);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, l, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, Collection collection) {
+        try {
+            return super.put(s, collection);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, collection, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, Map map) {
+        try {
+            return super.put(s, map);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, map, e), e);
+        }
+    }
+
+    @Override
+    public JSONObject put(String s, Object o) {
+        try {
+            return super.put(s, o);
+        } catch (JSONException e) {
+            throw new RuntimeException(getErrorMessage(s, o, e), e);
+        }
+    }
+
+    private String getErrorMessage(String key, Object value, JSONException e) {
+        return "Trying to add invalid JSON object with key '" + key +
+                "' and value '" + value + "' - " + e.getMessage();
+    }
+
+}
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
index add69403455..6a06a6362f5 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
@@ -1,7 +1,7 @@
 // Copyright 2019 Oath Inc. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 package com.yahoo.container.jdisc.state;
 
-import com.fasterxml.jackson.databind.JsonNode;
+import org.json.JSONObject;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -13,9 +13,9 @@ import java.util.List;
  */
 public class MetricGatherer {
 
-    static List<JsonNode> getAdditionalMetrics() {
+    static List<JSONObject> getAdditionalMetrics() {
         FileWrapper fileWrapper = new FileWrapper();
-        List<JsonNode> packetList = new ArrayList<>();
+        List<JSONObject> packetList = new ArrayList<>();
         packetList.add(CoredumpGatherer.gatherCoredumpMetrics(fileWrapper));
         if (System.getProperty("os.name").contains("nux"))
             packetList.add(HostLifeGatherer.getHostLifePacket(fileWrapper));
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
index e8d829eafb1..3d3f0e4b677 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
@@ -1,11 +1,6 @@
 // Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 package com.yahoo.container.jdisc.state;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ArrayNode;
-import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.google.inject.Inject;
 import com.yahoo.collections.Tuple2;
 import com.yahoo.component.provider.ComponentRegistry;
@@ -18,6 +13,9 @@ import com.yahoo.jdisc.handler.ResponseDispatch;
 import com.yahoo.jdisc.handler.ResponseHandler;
 import com.yahoo.jdisc.http.HttpHeaders;
 import com.yahoo.metrics.MetricsPresentationConfig;
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
 
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
@@ -46,8 +44,6 @@ import static com.yahoo.container.jdisc.state.StateHandler.getSnapshotPreprocess
  */
 public class MetricsPacketsHandler extends AbstractRequestHandler {
 
-    private static final ObjectMapper jsonMapper = new ObjectMapper();
-
     static final String APPLICATION_KEY = "application";
     static final String TIMESTAMP_KEY   = "timestamp";
     static final String STATUS_CODE_KEY = "status_code";
@@ -101,19 +97,19 @@ public class MetricsPacketsHandler extends AbstractRequestHandler {
             }
             String output = jsonToString(getStatusPacket()) + getAllMetricsPackets() + "\n";
             return output.getBytes(StandardCharsets.UTF_8);
-        } catch (JsonProcessingException e) {
+        } catch (JSONException e) {
             throw new RuntimeException("Bad JSON construction.", e);
         }
     }
 
-    private byte[] getMetricsArray() throws JsonProcessingException {
-        ObjectNode root = jsonMapper.createObjectNode();
-        ArrayNode jsonArray = jsonMapper.createArrayNode();
-        jsonArray.add(getStatusPacket());
+    private byte[] getMetricsArray() throws JSONException {
+        JSONObject root = new JSONObject();
+        JSONArray jsonArray = new JSONArray();
+        jsonArray.put(getStatusPacket());
         getPacketsForSnapshot(getSnapshot(), applicationName, timer.currentTimeMillis())
-                .forEach(jsonArray::add);
-        MetricGatherer.getAdditionalMetrics().forEach(jsonArray::add);
-        root.set("metrics", jsonArray);
+                .forEach(jsonArray::put);
+        MetricGatherer.getAdditionalMetrics().forEach(jsonArray::put);
+        root.put("metrics", jsonArray);
         return jsonToString(root)
                 .getBytes(StandardCharsets.UTF_8);
     }
@@ -121,8 +117,8 @@ public class MetricsPacketsHandler extends AbstractRequestHandler {
     /**
      * Exactly one status packet is added to the response.
      */
-    private JsonNode getStatusPacket() {
-        ObjectNode packet = jsonMapper.createObjectNode();
+    private JSONObject getStatusPacket() throws JSONException {
+        JSONObject packet = new JSONObjectWithLegibleException();
         packet.put(APPLICATION_KEY, applicationName);
 
         StateMonitor.Status status = monitor.status();
@@ -131,15 +127,14 @@ public class MetricsPacketsHandler extends AbstractRequestHandler {
         return packet;
     }
 
-    private static String jsonToString(JsonNode jsonObject) throws JsonProcessingException {
-        return jsonMapper.writerWithDefaultPrettyPrinter()
-                .writeValueAsString(jsonObject);
+    private String jsonToString(JSONObject jsonObject) throws JSONException {
+        return jsonObject.toString(4);
     }
 
-    private String getAllMetricsPackets() throws JsonProcessingException {
+    private String getAllMetricsPackets() throws JSONException {
         StringBuilder ret = new StringBuilder();
-        List<JsonNode> metricsPackets = getPacketsForSnapshot(getSnapshot(), applicationName, timer.currentTimeMillis());
-        for (JsonNode packet : metricsPackets) {
+        List<JSONObject> metricsPackets = getPacketsForSnapshot(getSnapshot(), applicationName, timer.currentTimeMillis());
+        for (JSONObject packet : metricsPackets) {
             ret.append(PACKET_SEPARATOR); // For legibility and parsing in unit tests
             ret.append(jsonToString(packet));
         }
@@ -155,16 +150,16 @@ public class MetricsPacketsHandler extends AbstractRequestHandler {
         }
     }
 
-    private List<JsonNode> getPacketsForSnapshot(MetricSnapshot metricSnapshot, String application, long timestamp) {
+    private List<JSONObject> getPacketsForSnapshot(MetricSnapshot metricSnapshot, String application, long timestamp) throws JSONException {
         if (metricSnapshot == null) return Collections.emptyList();
 
-        List<JsonNode> packets = new ArrayList<>();
+        List<JSONObject> packets = new ArrayList<>();
 
         for (Map.Entry<MetricDimensions, MetricSet> snapshotEntry : metricSnapshot) {
             MetricDimensions metricDimensions = snapshotEntry.getKey();
             MetricSet metricSet = snapshotEntry.getValue();
 
-            ObjectNode packet = jsonMapper.createObjectNode();
+            JSONObjectWithLegibleException packet = new JSONObjectWithLegibleException();
             addMetaData(timestamp, application, packet);
             addDimensions(metricDimensions, packet);
             addMetrics(metricSet, packet);
@@ -173,27 +168,27 @@ public class MetricsPacketsHandler extends AbstractRequestHandler {
         return packets;
     }
 
-    private void addMetaData(long timestamp, String application, ObjectNode packet) {
+    private void addMetaData(long timestamp, String application, JSONObjectWithLegibleException packet) {
         packet.put(APPLICATION_KEY, application);
         packet.put(TIMESTAMP_KEY, TimeUnit.MILLISECONDS.toSeconds(timestamp));
     }
 
-    private void addDimensions(MetricDimensions metricDimensions, ObjectNode packet) {
+    private void addDimensions(MetricDimensions metricDimensions, JSONObjectWithLegibleException packet) throws JSONException {
         if (metricDimensions == null) return;
 
         Iterator<Map.Entry<String, String>> dimensionsIterator = metricDimensions.iterator();
         if (dimensionsIterator.hasNext()) {
-            ObjectNode jsonDim = jsonMapper.createObjectNode();
-            packet.set(DIMENSIONS_KEY, jsonDim);
+            JSONObject jsonDim = new JSONObjectWithLegibleException();
+            packet.put(DIMENSIONS_KEY, jsonDim);
             for (Map.Entry<String, String> dimensionEntry : metricDimensions) {
                 jsonDim.put(dimensionEntry.getKey(), dimensionEntry.getValue());
             }
         }
     }
 
-    private void addMetrics(MetricSet metricSet, ObjectNode packet) {
-        ObjectNode metrics = jsonMapper.createObjectNode();
-        packet.set(METRICS_KEY, metrics);
+    private void addMetrics(MetricSet metricSet, JSONObjectWithLegibleException packet) throws JSONException {
+        JSONObjectWithLegibleException metrics = new JSONObjectWithLegibleException();
+        packet.put(METRICS_KEY, metrics);
         for (Map.Entry<String, MetricValue> metric : metricSet) {
             String name = metric.getKey();
             MetricValue value = metric.getValue();
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
index 1eb34e15258..b14dc50edcb 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
@@ -1,11 +1,6 @@
 // Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 package com.yahoo.container.jdisc.state;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ArrayNode;
-import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.google.inject.Inject;
 import com.yahoo.collections.Tuple2;
 import com.yahoo.component.Vtag;
@@ -21,16 +16,21 @@ import com.yahoo.jdisc.handler.ResponseHandler;
 import com.yahoo.jdisc.http.HttpHeaders;
 import com.yahoo.metrics.MetricsPresentationConfig;
 
-import java.io.ByteArrayOutputStream;
-import java.io.PrintStream;
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+
 import java.net.URI;
 import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
+import java.io.PrintStream;
+import java.io.ByteArrayOutputStream;
 
 /**
  * A handler which returns state (health) information from this container instance: Status, metrics and vespa version.
@@ -39,8 +39,6 @@ import java.util.concurrent.TimeUnit;
  */
 public class StateHandler extends AbstractRequestHandler {
 
-    private static final ObjectMapper jsonMapper = new ObjectMapper();
-
     public static final String STATE_API_ROOT = "/state/v1";
     private static final String METRICS_PATH = "metrics";
     private static final String HISTOGRAMS_PATH = "metrics/histograms";
@@ -126,16 +124,17 @@ public class StateHandler extends AbstractRequestHandler {
             }
             base.append(STATE_API_ROOT);
             String uriBase = base.toString();
-            ArrayNode linkList = jsonMapper.createArrayNode();
+            JSONArray linkList = new JSONArray();
             for (String api : new String[] {METRICS_PATH, CONFIG_GENERATION_PATH, HEALTH_PATH, VERSION_PATH}) {
-                ObjectNode resource = jsonMapper.createObjectNode();
+                JSONObject resource = new JSONObject();
                 resource.put("url", uriBase + "/" + api);
-                linkList.add(resource);
+                linkList.put(resource);
             }
-            JsonNode resources = jsonMapper.createObjectNode().set("resources", linkList);
-            return toPrettyString(resources);
-        } catch (JsonProcessingException e) {
-            throw new RuntimeException("Bad JSON construction", e);
+            return new JSONObjectWithLegibleException()
+                    .put("resources", linkList)
+                    .toString(4).getBytes(StandardCharsets.UTF_8);
+        } catch (JSONException e) {
+            throw new RuntimeException("Bad JSON construction.", e);
         }
     }
 
@@ -155,31 +154,31 @@ public class StateHandler extends AbstractRequestHandler {
 
     private static byte[] buildConfigOutput(ApplicationMetadataConfig config) {
         try {
-            return toPrettyString(
-                    jsonMapper.createObjectNode()
-                            .set(CONFIG_GENERATION_PATH, jsonMapper.createObjectNode()
-                                    .put("generation", config.generation())
-                                    .set("container", jsonMapper.createObjectNode()
-                                            .put("generation", config.generation()))));
-        } catch (JsonProcessingException e) {
+            return new JSONObjectWithLegibleException()
+                    .put(CONFIG_GENERATION_PATH, new JSONObjectWithLegibleException()
+                            .put("generation", config.generation())
+                            .put("container", new JSONObjectWithLegibleException()
+                                    .put("generation", config.generation())))
+                    .toString(4).getBytes(StandardCharsets.UTF_8);
+        } catch (JSONException e) {
             throw new RuntimeException("Bad JSON construction.", e);
         }
     }
 
     private static byte[] buildVersionOutput() {
         try {
-            return toPrettyString(
-                    jsonMapper.createObjectNode()
-                            .put("version", Vtag.currentVersion.toString()));
-        } catch (JsonProcessingException e) {
+            return new JSONObjectWithLegibleException()
+                    .put("version", Vtag.currentVersion)
+                    .toString(4).getBytes(StandardCharsets.UTF_8);
+        } catch (JSONException e) {
             throw new RuntimeException("Bad JSON construction.", e);
         }
     }
 
     private byte[] buildMetricOutput(String consumer) {
         try {
-            return toPrettyString(buildJsonForConsumer(consumer));
-        } catch (JsonProcessingException e) {
+            return buildJsonForConsumer(consumer).toString(4).getBytes(StandardCharsets.UTF_8);
+        } catch (JSONException e) {
             throw new RuntimeException("Bad JSON construction.", e);
         }
     }
@@ -192,11 +191,11 @@ public class StateHandler extends AbstractRequestHandler {
         return baos.toByteArray();
     }
 
-    private ObjectNode buildJsonForConsumer(String consumer) {
-        ObjectNode ret = jsonMapper.createObjectNode();
+    private JSONObjectWithLegibleException buildJsonForConsumer(String consumer) throws JSONException {
+        JSONObjectWithLegibleException ret = new JSONObjectWithLegibleException();
         ret.put("time", timer.currentTimeMillis());
-        ret.set("status", jsonMapper.createObjectNode().put("code", getStatus().name()));
-        ret.set(METRICS_PATH, buildJsonForSnapshot(consumer, getSnapshot()));
+        ret.put("status", new JSONObjectWithLegibleException().put("code", getStatus().name()));
+        ret.put(METRICS_PATH, buildJsonForSnapshot(consumer, getSnapshot()));
         return ret;
     }
 
@@ -213,12 +212,12 @@ public class StateHandler extends AbstractRequestHandler {
         return monitor.status();
     }
 
-    private ObjectNode buildJsonForSnapshot(String consumer, MetricSnapshot metricSnapshot) {
+    private JSONObjectWithLegibleException buildJsonForSnapshot(String consumer, MetricSnapshot metricSnapshot) throws JSONException {
         if (metricSnapshot == null) {
-            return jsonMapper.createObjectNode();
+            return new JSONObjectWithLegibleException();
         }
-        ObjectNode jsonMetric = jsonMapper.createObjectNode();
-        jsonMetric.set("snapshot", jsonMapper.createObjectNode()
+        JSONObjectWithLegibleException jsonMetric = new JSONObjectWithLegibleException();
+        jsonMetric.put("snapshot", new JSONObjectWithLegibleException()
                 .put("from", metricSnapshot.getFromTime(TimeUnit.MILLISECONDS) / 1000.0)
                 .put("to", metricSnapshot.getToTime(TimeUnit.MILLISECONDS) / 1000.0));
 
@@ -226,16 +225,16 @@ public class StateHandler extends AbstractRequestHandler {
         long periodInMillis = metricSnapshot.getToTime(TimeUnit.MILLISECONDS) -
                               metricSnapshot.getFromTime(TimeUnit.MILLISECONDS);
         for (Tuple tuple : collapseMetrics(metricSnapshot, consumer)) {
-            ObjectNode jsonTuple = jsonMapper.createObjectNode();
+            JSONObjectWithLegibleException jsonTuple = new JSONObjectWithLegibleException();
             jsonTuple.put("name", tuple.key);
             if (tuple.val instanceof CountMetric) {
                 CountMetric count = (CountMetric)tuple.val;
-                jsonTuple.set("values", jsonMapper.createObjectNode()
+                jsonTuple.put("values", new JSONObjectWithLegibleException()
                         .put("count", count.getCount())
                         .put("rate", (count.getCount() * 1000.0) / periodInMillis));
             } else if (tuple.val instanceof GaugeMetric) {
                 GaugeMetric gauge = (GaugeMetric) tuple.val;
-                ObjectNode valueFields = jsonMapper.createObjectNode();
+                JSONObjectWithLegibleException valueFields = new JSONObjectWithLegibleException();
                 valueFields.put("average", gauge.getAverage())
                         .put("sum", gauge.getSum())
                         .put("count", gauge.getCount())
@@ -248,27 +247,22 @@ public class StateHandler extends AbstractRequestHandler {
                         valueFields.put(prefixAndValue.first + "percentile", prefixAndValue.second.doubleValue());
                     }
                 }
-                jsonTuple.set("values", valueFields);
+                jsonTuple.put("values", valueFields);
             } else {
                 throw new UnsupportedOperationException(tuple.val.getClass().getName());
             }
             if (tuple.dim != null) {
                 Iterator<Map.Entry<String, String>> it = tuple.dim.iterator();
                 if (it.hasNext() && includeDimensions) {
-                    ObjectNode jsonDim = jsonMapper.createObjectNode();
+                    JSONObjectWithLegibleException jsonDim = new JSONObjectWithLegibleException();
                     while (it.hasNext()) {
                         Map.Entry<String, String> entry = it.next();
                         jsonDim.put(entry.getKey(), entry.getValue());
                     }
-                    jsonTuple.set("dimensions", jsonDim);
+                    jsonTuple.put("dimensions", jsonDim);
                 }
             }
-            ArrayNode values = (ArrayNode) jsonMetric.get("values");
-            if (values == null) {
-                values = jsonMapper.createArrayNode();
-                jsonMetric.set("values", values);
-            }
-            values.add(jsonTuple);
+            jsonMetric.append("values", jsonTuple);
         }
         return jsonMetric;
     }
@@ -322,12 +316,6 @@ public class StateHandler extends AbstractRequestHandler {
         return metrics;
     }
 
-    private static byte[] toPrettyString(JsonNode resources) throws JsonProcessingException {
-        return jsonMapper.writerWithDefaultPrettyPrinter()
-                .writeValueAsString(resources)
-                .getBytes();
-    }
-
     static class Tuple {
 
         final MetricDimensions dim;