aboutsummaryrefslogtreecommitdiffstats
path: root/container-core/src/main/java/com/yahoo/container/jdisc/state
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2020-11-18 20:37:35 +0100
committerJon Bratseth <bratseth@gmail.com>2020-11-18 20:37:35 +0100
commitb01ecd72d26a45ff4b498881446f5e62237c64be (patch)
treec6b4626e262d234900929132e4554b00cda03c49 /container-core/src/main/java/com/yahoo/container/jdisc/state
parent804b5ea7d3822847d2b732c79fd35a5eceba15b4 (diff)
Non-functional-changes-only
Diffstat (limited to 'container-core/src/main/java/com/yahoo/container/jdisc/state')
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/FileWrapper.java1
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/GaugeMetric.java2
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java1
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java5
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java6
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java1
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/SnapshotProvider.java2
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/state/StateMonitor.java1
8 files changed, 13 insertions, 6 deletions
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/FileWrapper.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/FileWrapper.java
index 6e22e02eb5b..3e127b87017 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/FileWrapper.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/FileWrapper.java
@@ -24,4 +24,5 @@ public class FileWrapper {
boolean isRegularFile(Path path) {
return Files.isRegularFile(path);
}
+
}
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/GaugeMetric.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/GaugeMetric.java
index 9b89b8abe52..9a195710c8f 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/GaugeMetric.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/GaugeMetric.java
@@ -20,7 +20,7 @@ public final class GaugeMetric extends MetricValue {
private double min;
private double sum;
private long count;
- private Optional<List<Tuple2<String, Double>>> percentiles;
+ private final Optional<List<Tuple2<String, Double>>> percentiles;
private GaugeMetric(double last, double max, double min, double sum, long count, Optional<List<Tuple2<String, Double>>> percentiles) {
this.last = last;
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
index 080a5a8dc32..730f7bc13cd 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/HostLifeGatherer.java
@@ -44,4 +44,5 @@ public class HostLifeGatherer {
return jsonObject;
}
+
}
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java
index dc1bfb89197..d22dd9d6f4b 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/JSONObjectWithLegibleException.java
@@ -13,6 +13,7 @@ import java.util.Map;
* @author gjoranv
*/
class JSONObjectWithLegibleException extends JSONObject {
+
@Override
public JSONObject put(String s, boolean b) {
try {
@@ -80,7 +81,7 @@ class JSONObjectWithLegibleException extends JSONObject {
private String getErrorMessage(String key, Object value, JSONException e) {
return "Trying to add invalid JSON object with key '" + key +
- "' and value '" + value +
- "' - " + e.getMessage();
+ "' and value '" + value + "' - " + e.getMessage();
}
+
}
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
index 061ce7138ad..6a06a6362f5 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricGatherer.java
@@ -7,8 +7,9 @@ import java.util.ArrayList;
import java.util.List;
/**
+ * Gathers metrics regarding currently processing coredumps and host life.
+ *
* @author olaa
- * Gathers metrics regarding currently processing coredumps and host life
*/
public class MetricGatherer {
@@ -17,7 +18,8 @@ public class MetricGatherer {
List<JSONObject> packetList = new ArrayList<>();
packetList.add(CoredumpGatherer.gatherCoredumpMetrics(fileWrapper));
if (System.getProperty("os.name").contains("nux"))
- packetList.add(HostLifeGatherer.getHostLifePacket(fileWrapper));
+ packetList.add(HostLifeGatherer.getHostLifePacket(fileWrapper));
return packetList;
}
+
}
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
index d1036db5c6f..c1a6f650a9c 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java
@@ -43,6 +43,7 @@ import static com.yahoo.container.jdisc.state.StateHandler.getSnapshotPreprocess
* @author gjoranv
*/
public class MetricsPacketsHandler extends AbstractRequestHandler {
+
static final String APPLICATION_KEY = "application";
static final String TIMESTAMP_KEY = "timestamp";
static final String STATUS_CODE_KEY = "status_code";
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/SnapshotProvider.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/SnapshotProvider.java
index 4967fd1f162..d693bf97bd8 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/SnapshotProvider.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/SnapshotProvider.java
@@ -7,7 +7,7 @@ import java.io.PrintStream;
* An interface for components supplying a state snapshot where persistence and
* other pre-processing has been done.
*
- * @author <a href="mailto:steinar@yahoo-inc.com">Steinar Knutsen</a>
+ * @author Steinar Knutsen
*/
public interface SnapshotProvider {
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateMonitor.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateMonitor.java
index ccd0864b3ab..40a0ef10fbc 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateMonitor.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateMonitor.java
@@ -136,4 +136,5 @@ public class StateMonitor extends AbstractComponent {
}
});
}
+
}