Replace all usages of Arrays.asList with List.of where possible.

15 files changed, 27 insertions, 38 deletions

diff --git a/container-core/src/main/java/com/yahoo/component/chain/ChainedComponent.java b/container-core/src/main/java/com/yahoo/component/chain/ChainedComponent.java
index d98e7e9c730..2c2ee5226a6 100644
--- a/container-core/src/main/java/com/yahoo/component/chain/ChainedComponent.java
+++ b/container-core/src/main/java/com/yahoo/component/chain/ChainedComponent.java
@@ -11,7 +11,6 @@ import com.yahoo.component.chain.dependencies.Provides;
 import java.lang.annotation.Annotation;
 import java.lang.reflect.InvocationTargetException;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 
@@ -69,7 +68,7 @@ public abstract class ChainedComponent extends AbstractComponent {
     // TODO: move to vespajlib.
     private static List<String> allOf(List<String> symbols, String... otherSymbols) {
         List<String> result = new ArrayList<>(symbols);
-        result.addAll(Arrays.asList(otherSymbols));
+        result.addAll(List.of(otherSymbols));
         return result;
     }
 
@@ -87,7 +86,7 @@ public abstract class ChainedComponent extends AbstractComponent {
             Annotation annotation = component.getClass().getAnnotation(annotationClass);
             if (annotation != null) {
                 Object values = annotationClass.getMethod("value").invoke(annotation);
-                return Arrays.asList((String[])values);
+                return List.of((String[])values);
             }
             return List.of();
 
diff --git a/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java b/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
index fef23f3cc27..c0bc01be27c 100644
--- a/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
+++ b/container-core/src/main/java/com/yahoo/component/chain/dependencies/ordering/ChainBuilder.java
@@ -3,7 +3,6 @@ package com.yahoo.component.chain.dependencies.ordering;
 
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.LinkedHashMap;
@@ -50,7 +49,7 @@ public class ChainBuilder<T extends ChainedComponent> {
     }
 
     private Set<String> set(String... s) {
-        return new HashSet<>(Arrays.asList(s));
+        return new HashSet<>(List.of(s));
     }
 
     public PhaseNameProvider addPhase(Phase phase) {
diff --git a/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentGraph.java b/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentGraph.java
index 98b4d0f4d63..5db57250bdf 100644
--- a/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentGraph.java
+++ b/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentGraph.java
@@ -23,7 +23,6 @@ import java.lang.reflect.Type;
 import java.lang.reflect.TypeVariable;
 import java.lang.reflect.WildcardType;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -369,7 +368,7 @@ public class ComponentGraph {
     public static boolean isBindingAnnotation(Annotation annotation) {
         LinkedList<Class<?>> queue = new LinkedList<>();
         queue.add(annotation.getClass());
-        queue.addAll(Arrays.asList(annotation.getClass().getInterfaces()));
+        queue.addAll(List.of(annotation.getClass().getInterfaces()));
 
         while (!queue.isEmpty()) {
             Class<?> clazz = queue.removeFirst();
diff --git a/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentNode.java b/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentNode.java
index 4500a5636f4..dcc024ef2b1 100644
--- a/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentNode.java
+++ b/container-core/src/main/java/com/yahoo/container/di/componentgraph/core/ComponentNode.java
@@ -199,7 +199,7 @@ public class ComponentNode extends Node {
     @Override
     public boolean equals(Object other) {
         if (other instanceof ComponentNode that) {
-            return super.equals(that) && equalEdges(Arrays.asList(this.arguments), Arrays.asList(that.arguments)) && this.usedConfigs().equals(that.usedConfigs());
+            return super.equals(that) && equalEdges(List.of(this.arguments), List.of(that.arguments)) && this.usedConfigs().equals(that.usedConfigs());
         } else {
             return false;
         }
@@ -225,7 +225,7 @@ public class ComponentNode extends Node {
         List<Pair<Type, List<Annotation>>> ret = new ArrayList<>();
 
         for (int i = 0; i < types.length; i++) {
-            ret.add(new Pair<>(types[i], Arrays.asList(annotations[i])));
+            ret.add(new Pair<>(types[i], List.of(annotations[i])));
         }
         return ret;
     }
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
index ebd5c38e3a3..81ec0919441 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/StateHandler.java
@@ -31,7 +31,6 @@ import java.io.PrintStream;
 import java.net.URI;
 import java.nio.ByteBuffer;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
@@ -373,7 +372,7 @@ public class StateHandler extends AbstractRequestHandler implements CapabilityRe
 
     private boolean isPrometheusRequest(String query) {
         if (query == null) return false;
-        return Arrays.asList(query.split("&")).contains("format=prometheus");
+        return List.of(query.split("&")).contains("format=prometheus");
     }
 
     private String prometheusSanitizedName(String name) {
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/CookieHelper.java b/container-core/src/main/java/com/yahoo/jdisc/http/CookieHelper.java
index 3f32ca97a1c..1c9e6572d63 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/CookieHelper.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/CookieHelper.java
@@ -3,7 +3,6 @@ package com.yahoo.jdisc.http;
 
 import com.yahoo.jdisc.HeaderFields;
 
-import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
 
@@ -31,7 +30,7 @@ public class CookieHelper {
     public static void encodeSetCookieHeader(HeaderFields headers, List<Cookie> cookies) {
         headers.remove(HttpHeaders.Names.SET_COOKIE);
         for (Cookie cookie : cookies) {
-            headers.add(HttpHeaders.Names.SET_COOKIE, Cookie.toSetCookieHeaders(Arrays.asList(cookie)));
+            headers.add(HttpHeaders.Names.SET_COOKIE, Cookie.toSetCookieHeaders(List.of(cookie)));
         }
     }
 }
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/filter/DiscFilterResponse.java b/container-core/src/main/java/com/yahoo/jdisc/http/filter/DiscFilterResponse.java
index f96bb8b30ae..5070ef75c4d 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/filter/DiscFilterResponse.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/filter/DiscFilterResponse.java
@@ -9,7 +9,6 @@ import com.yahoo.jdisc.http.HttpResponse;
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.Enumeration;
 import java.util.List;
@@ -158,7 +157,7 @@ public class DiscFilterResponse {
 
     public void setCookie(String name, String value) {
         Cookie cookie = new Cookie(name, value);
-        setCookies(Arrays.asList(cookie));
+        setCookies(List.of(cookie));
     }
 
  }
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityRequestFilterChain.java b/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityRequestFilterChain.java
index 22874d2f987..dc8eb7daa7a 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityRequestFilterChain.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityRequestFilterChain.java
@@ -9,7 +9,6 @@ import com.yahoo.jdisc.handler.ResponseHandler;
 import com.yahoo.jdisc.http.HttpRequest;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 
@@ -42,7 +41,7 @@ public final class SecurityRequestFilterChain extends AbstractResource implement
     }
 
     public static RequestFilter newInstance(SecurityRequestFilter... filters) {
-        return newInstance(Arrays.asList(filters));
+        return newInstance(List.of(filters));
     }
 
     public static RequestFilter newInstance(List<? extends SecurityRequestFilter> filters) {
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityResponseFilterChain.java b/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityResponseFilterChain.java
index f3e722fbd61..16565cb5010 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityResponseFilterChain.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/filter/SecurityResponseFilterChain.java
@@ -8,7 +8,6 @@ import com.yahoo.jdisc.http.HttpRequest;
 
 import java.net.URI;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.Optional;
 
@@ -43,7 +42,7 @@ public class SecurityResponseFilterChain extends AbstractResource implements Res
     }
 
     public static ResponseFilter newInstance(SecurityResponseFilter... filters) {
-        return newInstance(Arrays.asList(filters));
+        return newInstance(List.of(filters));
     }
 
     public static ResponseFilter newInstance(List<? extends SecurityResponseFilter> filters) {
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/RequestFilterChain.java b/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/RequestFilterChain.java
index 2f50b5e319b..d6666060dbc 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/RequestFilterChain.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/RequestFilterChain.java
@@ -8,7 +8,6 @@ import com.yahoo.jdisc.http.HttpRequest;
 import com.yahoo.jdisc.http.filter.RequestFilter;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
 /**
@@ -40,7 +39,7 @@ public final class RequestFilterChain extends AbstractResource implements Reques
     }
 
     public static RequestFilter newInstance(RequestFilter... filters) {
-        return newInstance(Arrays.asList(filters));
+        return newInstance(List.of(filters));
     }
 
     public static RequestFilter newInstance(List<? extends RequestFilter> filters) {
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/ResponseFilterChain.java b/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/ResponseFilterChain.java
index 02d94a7529e..5145c7210f1 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/ResponseFilterChain.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/filter/chain/ResponseFilterChain.java
@@ -8,7 +8,6 @@ import com.yahoo.jdisc.application.ResourcePool;
 import com.yahoo.jdisc.http.filter.ResponseFilter;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
 /**
@@ -39,7 +38,7 @@ public final class ResponseFilterChain extends AbstractResource implements Respo
     }
 
     public static ResponseFilter newInstance(ResponseFilter... filters) {
-        return newInstance(Arrays.asList(filters));
+        return newInstance(List.of(filters));
     }
 
     public static ResponseFilter newInstance(List<? extends ResponseFilter> filters) {
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/CompletionHandlers.java b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/CompletionHandlers.java
index caa942b6a5c..23efec5f98d 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/CompletionHandlers.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/CompletionHandlers.java
@@ -3,7 +3,8 @@ package com.yahoo.jdisc.http.server.jetty;
 
 import com.yahoo.jdisc.handler.CompletionHandler;
 
-import java.util.Arrays;
+import java.util.List;
+
 
 /**
  * @author Simon Thoresen Hult
@@ -33,7 +34,7 @@ public class CompletionHandlers {
     }
 
     public static CompletionHandler wrap(CompletionHandler... handlers) {
-        return wrap(Arrays.asList(handlers));
+        return wrap(List.of(handlers));
     }
 
     public static CompletionHandler wrap(final Iterable<CompletionHandler> handlers) {
diff --git a/container-core/src/main/java/com/yahoo/metrics/simple/Point.java b/container-core/src/main/java/com/yahoo/metrics/simple/Point.java
index 5c7abe03596..4a1ae80fc69 100644
--- a/container-core/src/main/java/com/yahoo/metrics/simple/Point.java
+++ b/container-core/src/main/java/com/yahoo/metrics/simple/Point.java
@@ -74,13 +74,11 @@ public final class Point implements Context {
     @Override
     public String toString() {
         final int maxLen = 3;
-        StringBuilder builder = new StringBuilder();
-        builder.append("Point [location=")
-                .append(Arrays.asList(location).subList(0, Math.min(location.length, maxLen)))
-                .append(", dimensions=")
-                .append(Arrays.asList(dimensions).subList(0, Math.min(dimensions.length, maxLen)))
-                .append("]");
-        return builder.toString();
+        return "Point [location=" +
+                List.of(location).subList(0, Math.min(location.length, maxLen)) +
+                ", dimensions=" +
+                List.of(dimensions).subList(0, Math.min(dimensions.length, maxLen)) +
+                "]";
     }
 
     /**
diff --git a/container-core/src/main/java/com/yahoo/processing/handler/ProcessingTestDriver.java b/container-core/src/main/java/com/yahoo/processing/handler/ProcessingTestDriver.java
index cd22dc80a4c..b17e4229c4c 100644
--- a/container-core/src/main/java/com/yahoo/processing/handler/ProcessingTestDriver.java
+++ b/container-core/src/main/java/com/yahoo/processing/handler/ProcessingTestDriver.java
@@ -12,9 +12,9 @@ import com.yahoo.processing.Processor;
 import com.yahoo.processing.execution.chain.ChainRegistry;
 import com.yahoo.processing.rendering.Renderer;
 
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.List;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Executors;
 
@@ -38,12 +38,12 @@ public class ProcessingTestDriver extends RequestHandlerTestDriver {
     @SafeVarargs
     @SuppressWarnings("varargs")
     public ProcessingTestDriver(Chain<Processor> ... chains) {
-        this(Arrays.asList(chains), new ComponentRegistry<>());
+        this(List.of(chains), new ComponentRegistry<>());
     }
     @SafeVarargs
     @SuppressWarnings("varargs")
     public ProcessingTestDriver(String binding, Chain<Processor> ... chains) {
-        this(binding, Arrays.asList(chains), new ComponentRegistry<>());
+        this(binding, List.of(chains), new ComponentRegistry<>());
     }
     public ProcessingTestDriver(Collection<Chain<Processor>> chains, ComponentRegistry<Renderer> renderers) {
         this(createProcessingHandler(chains, renderers, AccessLog.voidAccessLog()));
diff --git a/container-core/src/main/java/com/yahoo/processing/request/CompoundName.java b/container-core/src/main/java/com/yahoo/processing/request/CompoundName.java
index cb4743cd83e..b4536a1c56b 100644
--- a/container-core/src/main/java/com/yahoo/processing/request/CompoundName.java
+++ b/container-core/src/main/java/com/yahoo/processing/request/CompoundName.java
@@ -173,7 +173,7 @@ public final class CompoundName {
         if (isEmpty()) return fromComponents(nameParts);
 
         List<String> newCompounds = new ArrayList<>(nameParts.length + compounds.size());
-        newCompounds.addAll(Arrays.asList(nameParts));
+        newCompounds.addAll(List.of(nameParts));
         newCompounds.addAll(this.compounds);
         return new CompoundName(newCompounds);
     }
@@ -204,7 +204,7 @@ public final class CompoundName {
             throw new IllegalArgumentException("Asked for the first " + n + " components but '" +
                                                this + "' only have " + compounds.size() + " components.");
         if (compounds.size() == n) return this;
-        if (compounds.size() == 0) return empty;
+        if (compounds.isEmpty()) return empty;
         if (compounds.size() - 1 == n) return first;
         return first.first(n);
     }
@@ -316,7 +316,7 @@ public final class CompoundName {
         for (String compound : compounds) all += compound.length();
         StringBuilder b = new StringBuilder(all);
         for (String compound : compounds) b.append(compound).append(".");
-        return b.length()==0 ? "" : b.substring(0, b.length()-1);
+        return b.isEmpty() ? "" : b.substring(0, b.length()-1);
     }
 
     /**