Fix Select and grouping bugs

- Deep copy the grouping structure on query copy.
  It is mutable but we have neglected doing this right until now.
- Fix a bug in the previous commit where the last constructed Query.Model was shared between all instances.
- Fix a bug in the previous commit where the query string instead of the query tree was reset when a new select
  expression is set.
- Don't use deprecated method.
- Clean up Javadoc and formatting.

1 files changed, 1 insertions, 0 deletions

diff --git a/container-search/src/main/java/com/yahoo/search/Query.java b/container-search/src/main/java/com/yahoo/search/Query.java
index cfb1c9a26be..53435941e26 100644
--- a/container-search/src/main/java/com/yahoo/search/Query.java
+++ b/container-search/src/main/java/com/yahoo/search/Query.java
@@ -972,6 +972,7 @@ public class Query extends com.yahoo.processing.Request implements Cloneable {
 
     private void copyPropertiesTo(Query clone) {
         clone.model = model.cloneFor(clone);
+        clone.select = select.cloneFor(clone);
         clone.ranking = (Ranking) ranking.clone();
         clone.presentation = (Presentation) presentation.clone();
         clone.context = getContext(true).cloneFor(clone);