Skip logging only for IllegalInputException

- Add IllegalInputException to signal cases where we know the exception
  is caused by illegal input received from the requestor.
- Only skip logging for IllegalInputException instead of the superclass
  IllegalArgumentException as that is also used to signal illegal
  arguments to methods due to bugs which are otherwise hard to debug.
- Throw IllegalInputException rather than IllegalArgumentException
  where appropriate.
- Deprecated QueryException as it was only used to be able to separate
  between query string and query parameter exceptions, and not doing
  that consistently, and is in a package we don't want more use of.
- Clean up some cases where the wrong exception was thrown.

1 files changed, 5 insertions, 5 deletions

diff --git a/container-search/src/main/java/com/yahoo/search/pagetemplates/PlaceholderMappingVisitor.java b/container-search/src/main/java/com/yahoo/search/pagetemplates/PlaceholderMappingVisitor.java
index c29e9615fe8..c37ea5667c0 100644
--- a/container-search/src/main/java/com/yahoo/search/pagetemplates/PlaceholderMappingVisitor.java
+++ b/container-search/src/main/java/com/yahoo/search/pagetemplates/PlaceholderMappingVisitor.java
@@ -19,16 +19,16 @@ import java.util.Map;
  */
 class PlaceholderMappingVisitor extends PageTemplateVisitor {
 
-    private Map<String, MapChoice> placeholderIdToChoice=new LinkedHashMap<>();
+    private final Map<String, MapChoice> placeholderIdToChoice = new LinkedHashMap<>();
 
     @Override
     public void visit(MapChoice mapChoice) {
-        List<String> placeholderIds=mapChoice.placeholderIds();
+        List<String> placeholderIds = mapChoice.placeholderIds();
         for (String placeholderId : placeholderIds) {
-            MapChoice existingChoice=placeholderIdToChoice.put(placeholderId,mapChoice);
-            if (existingChoice!=null)
+            MapChoice existingChoice = placeholderIdToChoice.put(placeholderId,mapChoice);
+            if (existingChoice != null)
                 throw new IllegalArgumentException("placeholder id '" + placeholderId + "' is referenced by both " +
-                        mapChoice + " and " + existingChoice + ": Only one reference is allowed");
+                                                   mapChoice + " and " + existingChoice + ": Only one reference is allowed");
         }
     }