diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-09-02 10:32:13 +0200 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2022-09-02 10:32:13 +0200 |
commit | 428f5ce099ec107b0ddff299b359839dd60629c2 (patch) | |
tree | 2da49b174015faeb25194b88ef5231024db8f70a /container-search/src/main | |
parent | 1583768921c1703475458428c9faf5d88acdff27 (diff) |
GC unused parameters.
Diffstat (limited to 'container-search/src/main')
-rw-r--r-- | container-search/src/main/java/com/yahoo/prelude/searcher/FieldCollapsingSearcher.java | 24 |
1 files changed, 5 insertions, 19 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/searcher/FieldCollapsingSearcher.java b/container-search/src/main/java/com/yahoo/prelude/searcher/FieldCollapsingSearcher.java index 6c39bc299fb..54c46b34163 100644 --- a/container-search/src/main/java/com/yahoo/prelude/searcher/FieldCollapsingSearcher.java +++ b/container-search/src/main/java/com/yahoo/prelude/searcher/FieldCollapsingSearcher.java @@ -14,7 +14,6 @@ import com.yahoo.search.result.Hit; import com.yahoo.search.searchchain.Execution; import com.yahoo.search.searchchain.PhaseNames; -import java.util.Iterator; import java.util.Map; /** @@ -32,7 +31,7 @@ public class FieldCollapsingSearcher extends Searcher { private static final CompoundName collapseSummaryName = new CompoundName("collapse.summary"); /** Maximum number of queries to send next searcher */ - private final int maxQueries = 4; + private static final int maxQueries = 4; /** * The max number of hits that will be preserved per unique @@ -49,16 +48,7 @@ public class FieldCollapsingSearcher extends Searcher { /** Create this searcher using default values for all settings */ public FieldCollapsingSearcher() { - this((String) null); - } - - /** - * Creates a collapser - * - * @param collapseField the default field to collapse on, or null to not collapse as default - */ - public FieldCollapsingSearcher(String collapseField) { - this(1, 2.0, collapseField); + this(1, 2.0); } @Inject @@ -78,9 +68,8 @@ public class FieldCollapsingSearcher extends Searcher { * @param extraFactor the percentage by which to scale up the * requested number of hits, to allow some hits to be removed * without refetching - * @param collapseField the field to collapse on. This is currently <b>ignored</b>. */ - public FieldCollapsingSearcher(int collapseSize, double extraFactor, String collapseField) { + public FieldCollapsingSearcher(int collapseSize, double extraFactor) { init(collapseSize, extraFactor); } @@ -158,14 +147,11 @@ public class FieldCollapsingSearcher extends Searcher { */ private void collapse(Result result, Map<String, Integer> knownCollapses, Result resultSource, String collapseField, int collapseSize) { - for (Iterator<Hit> it = resultSource.hits().iterator(); it.hasNext();) { - Hit unknownHit = it.next(); - - if (!(unknownHit instanceof FastHit)) { + for (Hit unknownHit : resultSource.hits()) { + if (!(unknownHit instanceof FastHit hit)) { result.hits().add(unknownHit); continue; } - FastHit hit = (FastHit) unknownHit; Object peek = hit.getField(collapseField); String collapseId = peek != null ? peek.toString() : null; if (collapseId == null) { |