diff options
author | Arne Juul <root@screwdriver.com> | 2023-10-10 12:56:18 +0000 |
---|---|---|
committer | Arne Juul <root@screwdriver.com> | 2023-10-10 12:56:18 +0000 |
commit | e3401296f36818430e580d9522772f6d5ab2e43f (patch) | |
tree | 9cbd1e3ce61cacdd2a625ef4435d398f27968feb /container-search/src/test/java/com/yahoo/search | |
parent | 54c1885ae2c0a672b67618e3871482c374d753ae (diff) |
simplify Normalizer
Diffstat (limited to 'container-search/src/test/java/com/yahoo/search')
-rw-r--r-- | container-search/src/test/java/com/yahoo/search/ranking/NormalizerTestCase.java | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/container-search/src/test/java/com/yahoo/search/ranking/NormalizerTestCase.java b/container-search/src/test/java/com/yahoo/search/ranking/NormalizerTestCase.java index 144ca0e8bae..7373fb489f4 100644 --- a/container-search/src/test/java/com/yahoo/search/ranking/NormalizerTestCase.java +++ b/container-search/src/test/java/com/yahoo/search/ranking/NormalizerTestCase.java @@ -12,7 +12,7 @@ public class NormalizerTestCase { @Test void requireLinearNormalizing() { - var n = new LinearNormalizer("foo", "bar", 10); + var n = new LinearNormalizer(10); assertEquals(0, n.addInput(-4.0)); assertEquals(1, n.addInput(-1.0)); assertEquals(2, n.addInput(-5.0)); @@ -22,14 +22,12 @@ public class NormalizerTestCase { assertEquals(0.25, n.getOutput(0)); assertEquals(0.5, n.getOutput(3)); assertEquals(1.0, n.getOutput(1)); - assertEquals("foo", n.name()); - assertEquals("bar", n.input()); assertEquals("linear", n.normalizing()); } @Test void requireLinearHandlesInfinity() { - var n = new LinearNormalizer("foo", "bar", 10); + var n = new LinearNormalizer(10); assertEquals(0, n.addInput(Double.NEGATIVE_INFINITY)); assertEquals(1, n.addInput(1.0)); assertEquals(2, n.addInput(9.0)); @@ -47,14 +45,12 @@ public class NormalizerTestCase { assertEquals(0.25, n.getOutput(5)); assertEquals(Double.POSITIVE_INFINITY, n.getOutput(6)); assertEquals(0.875, n.getOutput(7)); - assertEquals("foo", n.name()); - assertEquals("bar", n.input()); assertEquals("linear", n.normalizing()); } @Test void requireReciprocalNormalizing() { - var n = new ReciprocalRankNormalizer("foo", "bar", 10, 0.0); + var n = new ReciprocalRankNormalizer(10, 0.0); assertEquals(0, n.addInput(-4.1)); assertEquals(1, n.addInput(11.0)); assertEquals(2, n.addInput(-50.0)); @@ -64,14 +60,12 @@ public class NormalizerTestCase { assertEquals(0.3333333, n.getOutput(0), 0.00001); assertEquals(0.5, n.getOutput(3)); assertEquals(1.0, n.getOutput(1)); - assertEquals("foo", n.name()); - assertEquals("bar", n.input()); assertEquals("reciprocal-rank{k:0.0}", n.normalizing()); } @Test void requireReciprocalNormalizingWithK() { - var n = new ReciprocalRankNormalizer("foo", "bar", 10, 4.2); + var n = new ReciprocalRankNormalizer(10, 4.2); assertEquals(0, n.addInput(-4.1)); assertEquals(1, n.addInput(11.0)); assertEquals(2, n.addInput(-50.0)); @@ -81,14 +75,12 @@ public class NormalizerTestCase { assertEquals(1.0/7.2, n.getOutput(0), 0.00001); assertEquals(1.0/6.2, n.getOutput(3)); assertEquals(1.0/5.2, n.getOutput(1)); - assertEquals("foo", n.name()); - assertEquals("bar", n.input()); assertEquals("reciprocal-rank{k:4.2}", n.normalizing()); } @Test void requireReciprocalInfinities() { - var n = new ReciprocalRankNormalizer("foo", "bar", 10, 0.0); + var n = new ReciprocalRankNormalizer(10, 0.0); assertEquals(0, n.addInput(Double.NEGATIVE_INFINITY)); assertEquals(1, n.addInput(1.0)); assertEquals(2, n.addInput(9.0)); @@ -107,8 +99,6 @@ public class NormalizerTestCase { assertEquals(1.0/1.0, n.getOutput(6)); assertEquals(1.0/3.0, n.getOutput(7)); n.normalize(); - assertEquals("foo", n.name()); - assertEquals("bar", n.input()); assertEquals("reciprocal-rank{k:0.0}", n.normalizing()); } |