diff options
author | Geir Storli <geirst@yahooinc.com> | 2022-05-05 09:45:21 +0000 |
---|---|---|
committer | Geir Storli <geirst@yahooinc.com> | 2022-05-05 09:45:21 +0000 |
commit | a02b6c3c9ace991c82a9e1509d4d516688973fa5 (patch) | |
tree | 43893cbd69b04d462f04910f3ff1820109de328f /container-search/src/test | |
parent | 11fa502ceff0f4d7b7939289250441b94419eaa5 (diff) |
Name matching query properties using camelCase as done elsewhere.
Also provide the lowercase version as alias for backwards compatibility.
Diffstat (limited to 'container-search/src/test')
-rw-r--r-- | container-search/src/test/java/com/yahoo/search/query/MatchingTestCase.java | 22 |
1 files changed, 18 insertions, 4 deletions
diff --git a/container-search/src/test/java/com/yahoo/search/query/MatchingTestCase.java b/container-search/src/test/java/com/yahoo/search/query/MatchingTestCase.java index d117f88aa6a..9eb44eb0dc4 100644 --- a/container-search/src/test/java/com/yahoo/search/query/MatchingTestCase.java +++ b/container-search/src/test/java/com/yahoo/search/query/MatchingTestCase.java @@ -26,10 +26,10 @@ public class MatchingTestCase { @Test public void testQueryOverrides() { Query query = new Query("?query=test" + - "&ranking.matching.termwiselimit=0.7" + - "&ranking.matching.numthreadspersearch=17" + - "&ranking.matching.numsearchpartitions=13" + - "&ranking.matching.minhitsperthread=3" + + "&ranking.matching.termwiseLimit=0.7" + + "&ranking.matching.numThreadsPerSearch=17" + + "&ranking.matching.numSearchPartitions=13" + + "&ranking.matching.minHitsPerThread=3" + "&ranking.matching.postFilterThreshold=0.8" + "&ranking.matching.approximateThreshold=0.3"); assertEquals(Double.valueOf(0.7), query.getRanking().getMatching().getTermwiseLimit()); @@ -48,6 +48,20 @@ public class MatchingTestCase { assertEquals("0.3", query.getRanking().getProperties().get("vespa.matching.global_filter.lower_limit").get(0)); } + @Test + public void testBackwardsCompatibleQueryOverrides() { + // The lowercase aliases are supported to provide backwards compatibility of the properties that was wrongly named in the first place. + Query query = new Query("?query=test" + + "&ranking.matching.termwiselimit=0.7" + + "&ranking.matching.numthreadspersearch=17" + + "&ranking.matching.numsearchpartitions=13" + + "&ranking.matching.minhitsperthread=3"); + assertEquals(Double.valueOf(0.7), query.getRanking().getMatching().getTermwiseLimit()); + assertEquals(Integer.valueOf(17), query.getRanking().getMatching().getNumThreadsPerSearch()); + assertEquals(Integer.valueOf(13), query.getRanking().getMatching().getNumSearchPartitions()); + assertEquals(Integer.valueOf(3), query.getRanking().getMatching().getMinHitsPerThread()); + } + private void verifyException(String key, String value) { try { new Query("?query=test&ranking.matching."+key+"="+value); |