aboutsummaryrefslogtreecommitdiffstats
path: root/container-search
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 11:07:01 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 11:07:01 +0200
commit5443927d0f399ab20796de2294ffba4a936ead26 (patch)
tree6e240118872b7ed3f47b2bce31f86f0ec2f849f4 /container-search
parent0998024c0fff50455c1d0ee047194fd6afb11205 (diff)
query and location are 2 distinct dimensions
Diffstat (limited to 'container-search')
-rw-r--r--container-search/src/main/java/com/yahoo/prelude/fastsearch/VespaBackEndSearcher.java1
-rw-r--r--container-search/src/main/java/com/yahoo/search/dispatch/rpc/ProtobufSerialization.java7
2 files changed, 4 insertions, 4 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/fastsearch/VespaBackEndSearcher.java b/container-search/src/main/java/com/yahoo/prelude/fastsearch/VespaBackEndSearcher.java
index 33a287fac9b..430ad015493 100644
--- a/container-search/src/main/java/com/yahoo/prelude/fastsearch/VespaBackEndSearcher.java
+++ b/container-search/src/main/java/com/yahoo/prelude/fastsearch/VespaBackEndSearcher.java
@@ -95,7 +95,6 @@ public abstract class VespaBackEndSearcher extends PingableSearcher {
if (rankProfile == null) return true; // stay safe
if (rankProfile.hasSummaryFeatures()) return true;
if (query.getRanking().getListFeatures()) return true;
- if (query.getRanking().getLocation() != null) return true;
// (Don't just add other checks here as there is a return false above)
diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/rpc/ProtobufSerialization.java b/container-search/src/main/java/com/yahoo/search/dispatch/rpc/ProtobufSerialization.java
index 0e1565a108b..68beb16c254 100644
--- a/container-search/src/main/java/com/yahoo/search/dispatch/rpc/ProtobufSerialization.java
+++ b/container-search/src/main/java/com/yahoo/search/dispatch/rpc/ProtobufSerialization.java
@@ -142,6 +142,9 @@ public class ProtobufSerialization {
}
builder.setRankProfile(query.getRanking().getProfile());
+ if (ranking.getLocation() != null) {
+ builder.setGeoLocation(ranking.getLocation().toString());
+ }
if (includeQueryData) {
mergeQueryDataToDocsumRequest(query, builder);
}
@@ -165,9 +168,7 @@ public class ProtobufSerialization {
var featureMap = ranking.getFeatures().asMap();
builder.setQueryTreeBlob(serializeQueryTree(query.getModel().getQueryTree()));
- if (ranking.getLocation() != null) {
- builder.setGeoLocation(ranking.getLocation().toString());
- }
+
MapConverter.convertMapPrimitives(featureMap, builder::addFeatureOverrides);
MapConverter.convertMapTensors(featureMap, builder::addTensorFeatureOverrides);
if (query.getPresentation().getHighlight() != null) {