diff options
| author | Ola Aunrønning <olaa@verizonmedia.com> | 2021-05-18 13:36:52 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-18 13:36:52 +0200 |
| commit | 8bf0c34f48471825ce15666893c1282ae6e5a1c0 (patch) | |
| tree | 03b70725adc829a3b06ab29959a67b7d73842e3a /controller-api | |
| parent | 522921bb67d5b7b28809aa544135fe20360e00d8 (diff) | |
| parent | 69af24a2bd8adbcd594d9fcd2b7322d38b4494e2 (diff) | |
Merge pull request #17862 from vespa-engine/olaa/selectively-approve-vcmr
Only approve VCMRs manageable by automation
Diffstat (limited to 'controller-api')
2 files changed, 3 insertions, 3 deletions
diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/ChangeRequestClient.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/ChangeRequestClient.java index f8f54567bea..4fa195f1b05 100644 --- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/ChangeRequestClient.java +++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/ChangeRequestClient.java @@ -11,6 +11,6 @@ public interface ChangeRequestClient { /** Get upcoming change requests and updated status of previously stored requests */ List<ChangeRequest> getChangeRequests(List<ChangeRequest> changeRequests); - void approveChangeRequests(List<ChangeRequest> changeRequests); + void approveChangeRequest(ChangeRequest changeRequest); } diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/MockChangeRequestClient.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/MockChangeRequestClient.java index 10175f36991..e64b2ee3368 100644 --- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/MockChangeRequestClient.java +++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/vcmr/MockChangeRequestClient.java @@ -18,8 +18,8 @@ public class MockChangeRequestClient implements ChangeRequestClient { } @Override - public void approveChangeRequests(List<ChangeRequest> changeRequests) { - approvedChangeRequests.addAll(changeRequests); + public void approveChangeRequest(ChangeRequest changeRequest) { + approvedChangeRequests.add(changeRequest); } public void setUpcomingChangeRequests(List<ChangeRequest> changeRequests) { |