aboutsummaryrefslogtreecommitdiffstats
path: root/controller-server/src
diff options
context:
space:
mode:
authorjonmv <venstad@gmail.com>2022-06-17 11:24:02 +0200
committerjonmv <venstad@gmail.com>2022-06-17 11:24:02 +0200
commit2fb9037bf9f6e4a2c84eda208461c6404ca0c57f (patch)
treed3886acbd8c219914fa2967f0728ba9e425fb002 /controller-server/src
parenta90639a4c194cbf486d20eba8969340a4ce461ad (diff)
Avoid division by zero in success factor computation ಠ_ಠ
Diffstat (limited to 'controller-server/src')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
index 5178918aa48..974345330aa 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
@@ -20,7 +20,8 @@ public class ReadyJobsTrigger extends ControllerMaintainer {
@Override
public double maintain() {
TriggerResult result = controller().applications().deploymentTrigger().triggerReadyJobs();
- return result.triggered() * 1.0f / (result.triggered() + result.failed());
+ long total = result.triggered() + result.failed();
+ return total == 0 ? 1 : (double) result.triggered() / (result.triggered() + result.failed());
}
}