aboutsummaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2018-10-31 13:30:14 +0100
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2018-10-31 13:30:14 +0100
commit57ad6f6a6233efdde9ada807c921e905eaa3a2c3 (patch)
tree574eb3a8a28e6a4284909bced3b6ad12e078cf6e /controller-server
parent00d542c1bdb216b93547dbde46294f68e5632f10 (diff)
Delay commits during block window
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTrigger.java6
1 files changed, 2 insertions, 4 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTrigger.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTrigger.java
index 8bc61d6bc3b..a5896658e5f 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTrigger.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTrigger.java
@@ -480,10 +480,8 @@ public class DeploymentTrigger {
// ---------- Change management o_O ----------
private boolean acceptNewApplicationVersion(Application application) {
- if ( ! application.deploymentSpec().canChangeRevisionAt(clock.instant()) // If rolling out revision
- && application.changeAt(clock.instant()).application().isPresent() // which isn't complete, but in prod
- && ! application.deploymentJobs().hasFailures()) return false; // and isn't failing, delay the new submission.
- if (application.change().application().isPresent()) return true; // More application changes are ok.
+ if ( ! application.deploymentSpec().canChangeRevisionAt(clock.instant())) return false;
+ if (application.change().application().isPresent()) return true; // Replacing a previous application change is ok.
if (application.deploymentJobs().hasFailures()) return true; // Allow changes to fix upgrade problems.
return ! application.changeAt(clock.instant()).platform().isPresent();
}