Extract method

1 files changed, 11 insertions, 4 deletions

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/RoutingPolicies.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/RoutingPolicies.java
index fb2ec6ea815..0734ca4d3e7 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/RoutingPolicies.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/RoutingPolicies.java
@@ -203,13 +203,20 @@ public class RoutingPolicies {
             this.application = application;
             this.zone = zone;
             this.list = loadBalancers.stream()
-                                     // DNS no longer needs to maintain for load balancer in other states
-                                     // (e.g. inactive) than the following
-                                     .filter(lb -> lb.state() == LoadBalancer.State.active ||
-                                                   lb.state() == LoadBalancer.State.reserved)
+                                     .filter(AllocatedLoadBalancers::shouldUpdatePolicy)
                                      .collect(Collectors.toUnmodifiableList());
         }
 
+        private static boolean shouldUpdatePolicy(LoadBalancer loadBalancer) {
+            switch (loadBalancer.state()) {
+                case active:
+                case reserved: // This allows DNS updates to happen early, while an application is being prepared.
+                    return true;
+            }
+            // Any other state, such as inactive, is ignored.
+            return false;
+        }
+
     }
 
 }