aboutsummaryrefslogtreecommitdiffstats
path: root/document/src/tests/fieldvalue
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-08-21 09:14:35 +0200
committerGitHub <noreply@github.com>2019-08-21 09:14:35 +0200
commit991249b70460b61f3b73b53387dbc20357aedaa1 (patch)
tree7862378237365b2d0abbf51965f0620f165db0c9 /document/src/tests/fieldvalue
parentcb00b309ed537867e36e97dd2c9801c01d84489b (diff)
Revert "Revert "doc: -> id:""
Diffstat (limited to 'document/src/tests/fieldvalue')
-rw-r--r--document/src/tests/fieldvalue/referencefieldvalue_test.cpp15
1 files changed, 2 insertions, 13 deletions
diff --git a/document/src/tests/fieldvalue/referencefieldvalue_test.cpp b/document/src/tests/fieldvalue/referencefieldvalue_test.cpp
index d34bbff8a54..17fb5ac74e6 100644
--- a/document/src/tests/fieldvalue/referencefieldvalue_test.cpp
+++ b/document/src/tests/fieldvalue/referencefieldvalue_test.cpp
@@ -23,8 +23,8 @@ struct Fixture {
~Fixture();
};
- Fixture::Fixture() { }
- Fixture::~Fixture() { }
+ Fixture::Fixture() = default;
+ Fixture::~Fixture() = default;
}
using vespalib::IllegalArgumentException;
@@ -60,17 +60,6 @@ TEST_F("Exception is thrown if constructor doc ID type does not match referenced
"to reference of document type 'foo'");
}
-TEST_F("Exception is thrown if doc ID does not have a type", Fixture) {
- // Could have had a special cased message for this, but type-less IDs are
- // not expected to be allowed through the feed pipeline at all. We just
- // want to ensure it fails in a controlled fashion if encountered.
- EXPECT_EXCEPTION(
- ReferenceFieldValue(f.refType, DocumentId("doc:foo:bario")),
- IllegalArgumentException,
- "Can't assign document ID 'doc:foo:bario' (of type '') "
- "to reference of document type 'foo'");
-}
-
TEST_F("assign()ing a non-reference field value throws exception", Fixture) {
ReferenceFieldValue fv(f.refType);
EXPECT_EXCEPTION(fv.assign(StringFieldValue("waluigi time!!")),