Merge pull request #28850 from vespa-engine/jonmv/concrete-document-field-validation

Jonmv/concrete document field validation

1 files changed, 24 insertions, 0 deletions

diff --git a/documentgen-test/src/test/java/com/yahoo/vespa/config/DocumentGenPluginTest.java b/documentgen-test/src/test/java/com/yahoo/vespa/config/DocumentGenPluginTest.java
index 8c49ec9ba29..cae11d66d13 100644
--- a/documentgen-test/src/test/java/com/yahoo/vespa/config/DocumentGenPluginTest.java
+++ b/documentgen-test/src/test/java/com/yahoo/vespa/config/DocumentGenPluginTest.java
@@ -79,6 +79,7 @@ import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
 /**
@@ -500,6 +501,29 @@ public class DocumentGenPluginTest {
         assertEquals(book.getFieldValue("isbn"), new StringFieldValue("ISBN YEP"));
     }
 
+    @Test
+    public void testSetterValidation() {
+        Book book = new Book(new DocumentId("id:book:book::0"));
+
+        book.setAuthor("Herman Melville");
+        assertEquals("The string field value contains illegal code point 0x16",
+                     assertThrows(IllegalArgumentException.class,
+                                  () -> book.setAuthor("He\u0016rman Malville")).getMessage());
+
+        book.setRef(new DocumentId("id:ns:parent::foo"));
+        assertEquals("Can't assign document ID 'id:ns:common::bar' (of type 'common') to reference of document type 'parent'",
+                     assertThrows(IllegalArgumentException.class,
+                                  () -> book.setRef(new DocumentId("id:ns:common::bar"))).getMessage());
+
+        book.setStringmap(Map.of("foo", "bar"));
+        assertEquals("The string field value contains illegal code point 0x16",
+                     assertThrows(IllegalArgumentException.class,
+                                  () -> book.setStringmap(Map.of("foo", "bar\u0016"))).getMessage());
+        assertEquals("The string field value contains illegal code point 0x16",
+                     assertThrows(IllegalArgumentException.class,
+                                  () -> book.setStringmap(Map.of("bar\u0016", "foo"))).getMessage());
+    }
+
     public static class BookProcessor extends DocumentProcessor {
 
         public Progress process(Processing processing) {