diff options
| author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-12-01 13:54:04 +0000 |
|---|---|---|
| committer | Henning Baldersheim <balder@yahoo-inc.com> | 2020-12-01 13:54:04 +0000 |
| commit | 9741a44eaeec1f922696d776053ca2e108554d4e (patch) | |
| tree | 2f9cf0f2179ada3b4197c14e20fd4b9ac8608d5b /fnet | |
| parent | a7a0764e7e785f12ed40cd45d420e1b81991d402 (diff) | |
Make constructors explicit and config const.
Diffstat (limited to 'fnet')
| -rw-r--r-- | fnet/src/vespa/fnet/config.h | 2 | ||||
| -rw-r--r-- | fnet/src/vespa/fnet/transport.h | 10 | ||||
| -rw-r--r-- | fnet/src/vespa/fnet/transport_thread.h | 2 |
3 files changed, 8 insertions, 6 deletions
diff --git a/fnet/src/vespa/fnet/config.h b/fnet/src/vespa/fnet/config.h index 1dc372c98a7..508cb26c36f 100644 --- a/fnet/src/vespa/fnet/config.h +++ b/fnet/src/vespa/fnet/config.h @@ -17,7 +17,7 @@ public: uint32_t _maxOutputBufferSize; bool _tcpNoDelay; - explicit FNET_Config(); + FNET_Config(); FNET_Config & events_before_wakeup(uint32_t v) { if (v > 1) { _events_before_wakeup = v; diff --git a/fnet/src/vespa/fnet/transport.h b/fnet/src/vespa/fnet/transport.h index 0ac7f473789..6557c372a4d 100644 --- a/fnet/src/vespa/fnet/transport.h +++ b/fnet/src/vespa/fnet/transport.h @@ -57,12 +57,14 @@ private: using Threads = std::vector<Thread>; vespalib::AsyncResolver::SP _async_resolver; - vespalib::CryptoEngine::SP _crypto_engine; + vespalib::CryptoEngine::SP _crypto_engine; std::unique_ptr<vespalib::SyncableThreadExecutor> _work_pool; - Threads _threads; - FNET_Config _config; + Threads _threads; + const FNET_Config _config; public: + FNET_Transport(const FNET_Transport &) = delete; + FNET_Transport & operator = (const FNET_Transport &) = delete; /** * Construct a transport layer. To activate your newly created * transport object you need to call either the Start method to @@ -70,7 +72,7 @@ public: * the current thread become the transport thread. Main may only * be called for single-threaded transports. **/ - FNET_Transport(TransportConfig config); + explicit FNET_Transport(TransportConfig config); explicit FNET_Transport(uint32_t num_threads) : FNET_Transport(TransportConfig(num_threads)) {} diff --git a/fnet/src/vespa/fnet/transport_thread.h b/fnet/src/vespa/fnet/transport_thread.h index fd61d99a8ac..c649a677cb4 100644 --- a/fnet/src/vespa/fnet/transport_thread.h +++ b/fnet/src/vespa/fnet/transport_thread.h @@ -184,7 +184,7 @@ public: * * @param owner owning transport layer **/ - FNET_TransportThread(FNET_Transport &owner_in); + explicit FNET_TransportThread(FNET_Transport &owner_in); /** |