diff options
author | Bjørn Christian Seime <bjorncs@yahooinc.com> | 2022-11-16 12:07:59 +0100 |
---|---|---|
committer | Bjørn Christian Seime <bjorncs@yahooinc.com> | 2022-11-16 12:07:59 +0100 |
commit | 67e817445178aa0e7e7581bcda0d129c84334e77 (patch) | |
tree | 94d247af2f3d55e4138bf46f54872ac0a20945df /jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java | |
parent | bd281f83956c62cc0e42e328c4bac5b338e1f1cf (diff) |
Add test helper to construct filter request instance
Diffstat (limited to 'jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java')
-rw-r--r-- | jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java index aaf6ebf1aee..5b9f143a72b 100644 --- a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java +++ b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/misc/LocalhostFilterTest.java @@ -4,14 +4,11 @@ package com.yahoo.jdisc.http.filter.security.misc; import com.yahoo.container.jdisc.RequestHandlerTestDriver; import com.yahoo.jdisc.Response; import com.yahoo.jdisc.http.filter.DiscFilterRequest; +import com.yahoo.jdisc.http.filter.util.FilterTestUtils; import org.junit.jupiter.api.Test; -import org.mockito.Mockito; - -import java.net.URI; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNull; -import static org.mockito.Mockito.when; /** * @author mpolden @@ -34,12 +31,10 @@ public class LocalhostFilterTest { } private static DiscFilterRequest createRequest(String remoteAddr, String localAddr) { - DiscFilterRequest request = Mockito.mock(DiscFilterRequest.class); - when(request.getRemoteAddr()).thenReturn(remoteAddr); - when(request.getLocalAddr()).thenReturn(localAddr); - when(request.getMethod()).thenReturn("GET"); - when(request.getUri()).thenReturn(URI.create("http://localhost:8080/")); - return request; + return FilterTestUtils.newRequestBuilder() + .withUri("http://%s:8080/".formatted(localAddr)) + .withRemoteAddress(remoteAddr, 12345) + .build(); } private static void assertUnauthorized(DiscFilterRequest request) { |