Unify on List.of

1 files changed, 3 insertions, 4 deletions

diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/core/MetricsManager.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/core/MetricsManager.java
index b610c57cd99..60e85f3f9e4 100644
--- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/core/MetricsManager.java
+++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/core/MetricsManager.java
@@ -13,7 +13,6 @@ import ai.vespa.metricsproxy.service.VespaServices;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -107,7 +106,7 @@ public class MetricsManager {
      * NOTE: Use {@link #getMetrics(List, Instant)} instead, unless further processing of the metrics is necessary.
      */
     public List<MetricsPacket.Builder> getMetricsAsBuilders(List<VespaService> services, Instant startTime, ConsumerId consumerId) {
-        if (services.isEmpty()) return Collections.emptyList();
+        if (services.isEmpty()) return List.of();
 
         log.log(FINE, () -> "Updating services prior to fetching metrics, number of services= " + services.size());
         vespaServices.updateServices(services);
@@ -164,7 +163,7 @@ public class MetricsManager {
      * @return Health metrics for all matching services.
      */
     public List<MetricsPacket> getHealthMetrics(List<VespaService> services) {
-        if (services.isEmpty()) return Collections.emptyList();
+        if (services.isEmpty()) return List.of();
         vespaServices.updateServices(services);
 
         // TODO: Add global dimensions to health metrics?
@@ -190,7 +189,7 @@ public class MetricsManager {
 
     public void purgeExtraMetrics() {
         extraDimensions = new HashMap<>();
-        externalMetrics.setExtraMetrics(Collections.emptyList());
+        externalMetrics.setExtraMetrics(List.of());
     }
 
     /**