aboutsummaryrefslogtreecommitdiffstats
path: root/metrics-proxy
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2019-06-04 11:30:48 +0200
committergjoranv <gv@verizonmedia.com>2019-06-04 11:30:48 +0200
commita8a2a62e048ee97ee7e7819ae02e80ad03e04cea (patch)
tree35d2e4464fc2ef65060c87dd3c97b567a3d2dfb6 /metrics-proxy
parent37b33d2bdb07c41aa29a510ff54f740263a7922b (diff)
Minor non-functional improvements
Diffstat (limited to 'metrics-proxy')
-rw-r--r--metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java2
-rw-r--r--metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java11
2 files changed, 2 insertions, 11 deletions
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
index 604d020252f..4372adf34dc 100644
--- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
+++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
@@ -97,7 +97,7 @@ public class ConfigSentinelClient {
client.disconnect();
}
- protected static VespaService parseServiceString(String line, List<VespaService> services) {
+ static VespaService parseServiceString(String line, List<VespaService> services) {
String[] parts = line.split(" ");
if (parts.length < 3)
return null;
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
index e33674e87b0..653c79ba578 100644
--- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
+++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
@@ -66,7 +66,7 @@ public class SystemPoller {
try {
br = new BufferedReader(new FileReader("/proc/" + pid + "/smaps"));
} catch (FileNotFoundException ex) {
- markDead(service);
+ service.setAlive(false);
return size;
}
String line;
@@ -91,15 +91,6 @@ public class SystemPoller {
}
/**
- * Mark a service as dead.
- *
- * @param service The service to mark as dead.
- */
- private static void markDead(VespaService service) {
- service.setAlive(false);
- }
-
- /**
* Poll services for system metrics
*/
void poll() {