aboutsummaryrefslogtreecommitdiffstats
path: root/node-admin/src/test/java/com/yahoo
diff options
context:
space:
mode:
authorBjørn Christian Seime <bjorncs@yahooinc.com>2023-08-24 09:45:00 +0200
committerBjørn Christian Seime <bjorncs@yahooinc.com>2023-08-24 09:50:11 +0200
commit65655cbcadc890bcad907d6cc34995a926c29183 (patch)
treed0a80d02f648ca6981bea39c70e4073c2672fd5a /node-admin/src/test/java/com/yahoo
parenta5b9150a448ed1c30d13c64055a0bc534a1b4a95 (diff)
Add additional metrics for container memory
Diffstat (limited to 'node-admin/src/test/java/com/yahoo')
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/cgroup/CgroupTest.java8
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/container/ContainerStatsCollectorTest.java4
2 files changed, 10 insertions, 2 deletions
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/cgroup/CgroupTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/cgroup/CgroupTest.java
index c93d90329f7..dd81ea8e76a 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/cgroup/CgroupTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/cgroup/CgroupTest.java
@@ -106,8 +106,14 @@ public class CgroupTest {
shmem 8380416
file_mapped 1081344
file_dirty 135168
+ slab_reclaimable 1424320
""");
- assertEquals(69206016L, containerCgroup.memory().readFileSystemCache().value());
+ var stats = containerCgroup.memory().readStat();
+ assertEquals(69206016L, stats.file().value());
+ assertEquals(3481600L, stats.anon().value());
+ assertEquals(3552304L, stats.slab().value());
+ assertEquals(73728L, stats.sock().value());
+ assertEquals(1424320L, stats.slabReclaimable().value());
}
@Test
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/container/ContainerStatsCollectorTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/container/ContainerStatsCollectorTest.java
index d4598c8923f..2990e881640 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/container/ContainerStatsCollectorTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/container/ContainerStatsCollectorTest.java
@@ -2,6 +2,7 @@
package com.yahoo.vespa.hosted.node.admin.container;
import com.yahoo.vespa.hosted.node.admin.cgroup.Cgroup;
+import com.yahoo.vespa.hosted.node.admin.cgroup.MemoryController;
import com.yahoo.vespa.hosted.node.admin.cgroup.Size;
import com.yahoo.vespa.hosted.node.admin.configserver.noderepository.NodeSpec;
import com.yahoo.vespa.hosted.node.admin.nodeagent.NodeAgentContext;
@@ -97,7 +98,8 @@ public class ContainerStatsCollectorTest {
private void mockMemoryStats(ContainerId containerId) {
when(cgroup.resolveContainer(eq(containerId)).memory().readCurrent()).thenReturn(Size.from(1228017664L));
when(cgroup.resolveContainer(eq(containerId)).memory().readMax()).thenReturn(Size.from(2147483648L));
- when(cgroup.resolveContainer(eq(containerId)).memory().readFileSystemCache()).thenReturn(Size.from(470790144L));
+ when(cgroup.resolveContainer(eq(containerId)).memory().readStat()).thenReturn(
+ new MemoryController.Stats(Size.from(470790144L), Size.from(0), Size.from(0), Size.from(0), Size.from(0)));
}
private void mockCpuStats(ContainerId containerId) throws IOException {