aboutsummaryrefslogtreecommitdiffstats
path: root/node-admin/src/test
diff options
context:
space:
mode:
authorValerij Fredriksen <valerijf@yahooinc.com>2022-09-01 20:22:21 +0200
committerValerij Fredriksen <valerijf@yahooinc.com>2022-09-01 20:39:07 +0200
commitecc69cf2cdf7166de11d068beeb38dd5415d71c9 (patch)
treedcccf5bf1e86da60d56177ca4172714414fe49bc /node-admin/src/test
parentce4c8520cf3adca83805eeb02178c136f82c0acb (diff)
Non-functional cleanup
Diffstat (limited to 'node-admin/src/test')
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java4
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/coredump/CoredumpHandlerTest.java4
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/sync/ZstdCompressingInputStreamTest.java2
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeadmin/NodeAdminStateUpdaterTest.java2
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/fs/ContainerFileSystemTest.java2
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/process/ChildProcess2ImplTest.java4
6 files changed, 9 insertions, 9 deletions
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
index d98ca5d84f2..6db0bf0c730 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
@@ -141,7 +141,7 @@ public class StorageMaintainerTest {
}
@Test
- void not_run_if_not_enough_used() throws IOException {
+ void not_run_if_not_enough_used() {
NodeAgentContext context = NodeAgentContextImpl.builder(
NodeSpec.Builder.testSpec("h123a.domain.tld").realResources(new NodeResources(1, 1, 1, 1)).build())
.fileSystem(fileSystem).build();
@@ -152,7 +152,7 @@ public class StorageMaintainerTest {
}
@Test
- void deletes_correct_amount() throws IOException {
+ void deletes_correct_amount() {
NodeAgentContext context = NodeAgentContextImpl.builder(
NodeSpec.Builder.testSpec("h123a.domain.tld").realResources(new NodeResources(1, 1, 1, 1)).build())
.fileSystem(fileSystem).build();
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/coredump/CoredumpHandlerTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/coredump/CoredumpHandlerTest.java
index 31579fb7c9b..082a1f3de58 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/coredump/CoredumpHandlerTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/coredump/CoredumpHandlerTest.java
@@ -174,14 +174,14 @@ public class CoredumpHandlerTest {
}
@Test
- void cant_get_metadata_if_no_core_file() throws IOException {
+ void cant_get_metadata_if_no_core_file() {
assertThrows(IllegalStateException.class, () -> {
coredumpHandler.getMetadata(context, context.paths().of("/fake/path"), Map::of);
});
}
@Test
- void fails_to_get_core_file_if_only_compressed() throws IOException {
+ void fails_to_get_core_file_if_only_compressed() {
assertThrows(IllegalStateException.class, () -> {
ContainerPath coredumpDirectory = context.paths().of("/path/to/coredump/proccessing/id-123");
Files.createDirectories(coredumpDirectory);
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/sync/ZstdCompressingInputStreamTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/sync/ZstdCompressingInputStreamTest.java
index e6963175977..4eb5ca8a1cd 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/sync/ZstdCompressingInputStreamTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/sync/ZstdCompressingInputStreamTest.java
@@ -19,7 +19,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class ZstdCompressingInputStreamTest {
@Test
- void compression_test() throws Exception {
+ void compression_test() {
Random rnd = new Random();
byte[] data = new byte[(int) (100_000 * (10 + rnd.nextDouble()))];
rnd.nextBytes(data);
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeadmin/NodeAdminStateUpdaterTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeadmin/NodeAdminStateUpdaterTest.java
index 1197fd1469b..75dc4fffff8 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeadmin/NodeAdminStateUpdaterTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeadmin/NodeAdminStateUpdaterTest.java
@@ -58,7 +58,7 @@ public class NodeAdminStateUpdaterTest {
mockNodeRepo(NodeState.active, 4);
List<String> activeHostnames = nodeRepository.getNodes(hostHostname.value()).stream()
.map(NodeSpec::hostname)
- .collect(Collectors.toList());
+ .toList();
List<String> suspendHostnames = new ArrayList<>(activeHostnames);
suspendHostnames.add(hostHostname.value());
when(nodeAdmin.subsystemFreezeDuration()).thenReturn(Duration.ofSeconds(1));
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/fs/ContainerFileSystemTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/fs/ContainerFileSystemTest.java
index b26f0fe5bf8..29a78519724 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/fs/ContainerFileSystemTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/fs/ContainerFileSystemTest.java
@@ -60,7 +60,7 @@ class ContainerFileSystemTest {
unixPath.setOwnerId(500).setGroupId(200);
assertOwnership(containerPath, 500, 200, 10500, 11200);
- Files.write(containerPath, " world".getBytes(StandardCharsets.UTF_8), StandardOpenOption.APPEND);
+ Files.writeString(containerPath, " world", StandardOpenOption.APPEND);
assertOwnership(containerPath, 500, 200, 10500, 11200); // Owner should not have been updated as the file already existed
assertEquals("hello world", unixPath.readUtf8File());
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/process/ChildProcess2ImplTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/process/ChildProcess2ImplTest.java
index f209290cb14..53fdb52102b 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/process/ChildProcess2ImplTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/process/ChildProcess2ImplTest.java
@@ -100,7 +100,7 @@ public class ChildProcess2ImplTest {
when(processApi.waitFor(anyLong(), any())).thenReturn(true);
- Files.write(temporaryFile, "1234567890123".getBytes(StandardCharsets.UTF_8));
+ Files.writeString(temporaryFile, "1234567890123");
try (ChildProcess2Impl child =
new ChildProcess2Impl(commandLine, processApi, temporaryFile, timer)) {
@@ -130,7 +130,7 @@ public class ChildProcess2ImplTest {
when(processApi.waitFor(anyLong(), any())).thenReturn(false);
- Files.write(temporaryFile, "1234567890123".getBytes(StandardCharsets.UTF_8));
+ Files.writeString(temporaryFile, "1234567890123");
try (ChildProcess2Impl child =
new ChildProcess2Impl(commandLine, processApi, temporaryFile, timer)) {