aboutsummaryrefslogtreecommitdiffstats
path: root/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2022-04-12 12:36:43 +0200
committerMartin Polden <mpolden@mpolden.no>2022-04-12 12:40:41 +0200
commit20fb5a698573eef66c6c76df5ca4fd2185dc80ec (patch)
treeaf3b2c9c2b9586fa90abbc1e69da13dc225d97b6 /node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java
parent589e3662f610811e0e54992c6cc0e30d05c8630b (diff)
Fix after review feedback
Diffstat (limited to 'node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java')
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java
index 1f6862a1dc4..661ba531de5 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeFailer.java
@@ -157,7 +157,7 @@ public class NodeFailer extends NodeRepositoryMaintainer {
Instant graceTimeStart = clock().instant().minus(nodeRepository().nodes().suspended(node) ? suspendedDownTimeLimit : downTimeLimit);
if (downBefore(graceTimeStart, node) && !applicationSuspended(node)) {
// Allow a grace period after node re-activation
- if (!node.history().hasEventAfter(History.Event.Type.activated, graceTimeStart))
+ if (!node.history().hasLastEventAfter(graceTimeStart, History.Event.Type.activated))
failingNodes.add(new FailingNode(node, "Node has been down longer than " + downTimeLimit));
}
}
@@ -280,7 +280,7 @@ public class NodeFailer extends NodeRepositoryMaintainer {
/** Returns whether node is down, and has been down since before given instant */
private static boolean downBefore(Instant instant, Node node) {
- return node.isDown() && node.history().event(History.Event.Type.down).get().at().isBefore(instant);
+ return node.isDown() && node.history().hasLastEventBefore(instant, History.Event.Type.down);
}
private void wantToFail(Node node, boolean wantToFail, Mutex lock) {
@@ -293,8 +293,8 @@ public class NodeFailer extends NodeRepositoryMaintainer {
Instant startOfThrottleWindow = clock().instant().minus(throttlePolicy.throttleWindow);
NodeList allNodes = nodeRepository().nodes().list();
NodeList recentlyFailedNodes = allNodes.state(Node.State.failed)
- .matching(n -> n.history().hasEventAfter(History.Event.Type.failed,
- startOfThrottleWindow));
+ .matching(n -> n.history().hasLastEventAfter(startOfThrottleWindow, History.Event.Type.failed
+ ));
// Allow failing any node within policy
if (recentlyFailedNodes.size() < throttlePolicy.allowedToFailOf(allNodes.size())) return false;