diff options
author | Ola Aunronning <olaa@yahooinc.com> | 2024-01-24 15:50:11 +0100 |
---|---|---|
committer | Ola Aunronning <olaa@yahooinc.com> | 2024-01-24 15:50:11 +0100 |
commit | 9b1818fa5e19138309356387e3726b87b10e05a1 (patch) | |
tree | 2c09172025cc3e2c7b5dedfdab610816862ce829 /node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance | |
parent | e6f30b96ad5e1d32be4aa29db4c526f5ece50625 (diff) |
Added comment, TODO, and better naming
Diffstat (limited to 'node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance')
-rw-r--r-- | node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java index c2199de247c..fa1be83dbcf 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java @@ -64,13 +64,13 @@ public class ScalingSuggestionsMaintainer extends NodeRepositoryMaintainer { Application application = applications().get(applicationId).orElse(Application.empty(applicationId)); Optional<Cluster> cluster = application.cluster(clusterId); if (cluster.isEmpty()) return true; - var suggestion = autoscaler.suggest(application, cluster.get(), clusterNodes); + var suggestions = autoscaler.suggest(application, cluster.get(), clusterNodes); - if ( ! shouldUpdateSuggestion(cluster.get().suggestions(), suggestion)) + if ( ! shouldUpdateSuggestion(cluster.get().suggestions(), suggestions)) return true; // Wait only a short time for the lock to avoid interfering with change deployments try (Mutex lock = nodeRepository().applications().lock(applicationId, Duration.ofSeconds(1))) { - applications().get(applicationId).ifPresent(a -> updateSuggestion(suggestion, clusterId, a, lock)); + applications().get(applicationId).ifPresent(a -> updateSuggestion(suggestions, clusterId, a, lock)); return true; } catch (ApplicationLockException e) { |