Add ReadableAttributeVector accessor to IAttributeManager

Provides a unified interface for fetching both regular as well as
imported attributes. Exposing `ReadableAttributeVector` instead of
raw `AttributeVector` instances enforces that all access is done via
appropriate acquired read guards.

Refactor document selection processing code to use the new interface
in order to prepare for imported field support in selections.

1 files changed, 3 insertions, 3 deletions

diff --git a/searchcommon/src/vespa/searchcommon/attribute/i_attribute_functor.h b/searchcommon/src/vespa/searchcommon/attribute/i_attribute_functor.h
index 90484f8cc3a..c802730e6fe 100644
--- a/searchcommon/src/vespa/searchcommon/attribute/i_attribute_functor.h
+++ b/searchcommon/src/vespa/searchcommon/attribute/i_attribute_functor.h
@@ -17,19 +17,19 @@ class IConstAttributeFunctor
 {
 public:
     virtual void operator()(const IAttributeVector &attributeVector) = 0;
-    virtual ~IConstAttributeFunctor() { }
+    virtual ~IConstAttributeFunctor() = default;
 };
 
 class IAttributeFunctor
 {
 public:
     virtual void operator()(IAttributeVector &attributeVector) = 0;
-    virtual ~IAttributeFunctor() { }
+    virtual ~IAttributeFunctor() = default;
 };
 
 class IAttributeExecutor {
 public:
-    virtual ~IAttributeExecutor() { }
+    virtual ~IAttributeExecutor() = default;
     virtual void asyncForAttribute(const vespalib::string &name, std::unique_ptr<IAttributeFunctor> func) const = 0;
 };