- The metastore must be read in the master thread.

- The getMetaData belong to the handler, not the iterator.

2 files changed, 6 insertions, 5 deletions

diff --git a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.cpp b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.cpp
index d6ab781d777..5cc1041efba 100644
--- a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.cpp
+++ b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.cpp
@@ -31,10 +31,6 @@ search::DocumentMetaData MyScanIterator::next(uint32_t compactLidLimit, bool ret
     return search::DocumentMetaData();
 }
 
-search::DocumentMetaData MyScanIterator::getMetaData(uint32_t lid) const {
-    return search::DocumentMetaData(lid, TIMESTAMP_1, createBucketId(lid), GID_1);
-}
-
 document::BucketId
 MyScanIterator::createBucketId(uint32_t lid) const {
     return _bucketIdEqualLid ? document::BucketId(lid) : BUCKET_ID_1;
@@ -93,6 +89,11 @@ MyHandler::getIterator() const {
     return std::make_unique<MyScanIterator>(_lids[_iteratorCnt++], _bucketIdEqualLid);
 }
 
+search::DocumentMetaData
+MyHandler::getMetaData(uint32_t lid) const {
+    return search::DocumentMetaData(lid, TIMESTAMP_1, document::BucketId(lid), GID_1);
+}
+
 MoveOperation::UP
 MyHandler::createMoveOperation(const search::DocumentMetaData &document, uint32_t moveToLid) const {
     assert(document.lid > moveToLid);
diff --git a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.h b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.h
index ae83441737c..fb644d2bf02 100644
--- a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.h
+++ b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_common.h
@@ -54,7 +54,6 @@ struct MyScanIterator : public IDocumentScanIterator {
     ~MyScanIterator() override;
     bool valid() const override;
     search::DocumentMetaData next(uint32_t compactLidLimit, bool retry) override;
-    search::DocumentMetaData getMetaData(uint32_t lid) const override;
 
     document::BucketId createBucketId(uint32_t lid) const;
 };
@@ -83,6 +82,7 @@ struct MyHandler : public ILidSpaceCompactionHandler {
     uint32_t getSubDbId() const override { return 2; }
     LidUsageStats getLidStatus() const override;
     IDocumentScanIterator::UP getIterator() const override;
+    search::DocumentMetaData getMetaData(uint32_t lid) const override;
     MoveOperation::UP createMoveOperation(const search::DocumentMetaData &document,
                                           uint32_t moveToLid) const override;
     void handleMove(const MoveOperation &, IDestructorCallback::SP moveDoneCtx) override;