aboutsummaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2022-01-10 14:14:09 +0100
committerGitHub <noreply@github.com>2022-01-10 14:14:09 +0100
commit24e47f5e68aed5c983250dbfbe91d895acc3cb13 (patch)
treec7cbed3b51fdb940cd1827921041842722c6bba2 /searchcore
parent097cffa708c8aea92caad2f66ad062a2cbf536ba (diff)
parent7d0e4432d613e0d5a5e87a85459c8ca1130302ad (diff)
Merge pull request #20729 from vespa-engine/revert-20728-revert-20724-balder/default-disk-bloat-at-25-percent
Revert "Revert "Balder/default disk bloat at 25 percent""
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/tests/proton/server/memory_flush_config_updater/memory_flush_config_updater_test.cpp7
-rw-r--r--searchcore/src/vespa/searchcore/config/proton.def4
2 files changed, 6 insertions, 5 deletions
diff --git a/searchcore/src/tests/proton/server/memory_flush_config_updater/memory_flush_config_updater_test.cpp b/searchcore/src/tests/proton/server/memory_flush_config_updater/memory_flush_config_updater_test.cpp
index 01b46dd365f..7ff59a9f41a 100644
--- a/searchcore/src/tests/proton/server/memory_flush_config_updater/memory_flush_config_updater_test.cpp
+++ b/searchcore/src/tests/proton/server/memory_flush_config_updater/memory_flush_config_updater_test.cpp
@@ -205,12 +205,13 @@ TEST_F("require that we must go below low watermark for memory usage before usin
TEST_F("require that more disk bloat is allowed while node state is retired", Fixture)
{
+ constexpr double DEFAULT_DISK_BLOAT = 0.25;
f.notifyDiskMemUsage(ResourceUsageState(0.7, 0.3), belowLimit());
- TEST_DO(f.assertStrategyDiskConfig(0.2, 0.2));
+ TEST_DO(f.assertStrategyDiskConfig(DEFAULT_DISK_BLOAT, DEFAULT_DISK_BLOAT));
f.setNodeRetired(true);
- TEST_DO(f.assertStrategyDiskConfig((0.8 - ((0.3/0.7)*(1 - 0.2))) / 0.8, 1.0));
+ TEST_DO(f.assertStrategyDiskConfig((0.8 - ((0.3/0.7)*(1 - DEFAULT_DISK_BLOAT))) / 0.8, 1.0));
f.notifyDiskMemUsage(belowLimit(), belowLimit());
- TEST_DO(f.assertStrategyDiskConfig(0.2, 0.2));
+ TEST_DO(f.assertStrategyDiskConfig(DEFAULT_DISK_BLOAT, DEFAULT_DISK_BLOAT));
}
TEST_MAIN() { TEST_RUN_ALL(); }
diff --git a/searchcore/src/vespa/searchcore/config/proton.def b/searchcore/src/vespa/searchcore/config/proton.def
index 7e99c1a19aa..8a3550ac00b 100644
--- a/searchcore/src/vespa/searchcore/config/proton.def
+++ b/searchcore/src/vespa/searchcore/config/proton.def
@@ -54,7 +54,7 @@ flush.strategy enum {SIMPLE, MEMORY} default=MEMORY restart
flush.memory.maxmemory long default=4294967296
## Maximum total disk bloat factor before forcing flush.
-flush.memory.diskbloatfactor double default=0.2
+flush.memory.diskbloatfactor double default=0.25
## Max disk usage (in bytes) for all transaction logs before running flush.
## In this case the oldest component is flushed such that transaction log can be pruned and disk freed.
@@ -65,7 +65,7 @@ flush.memory.maxtlssize long default=21474836480
flush.memory.each.maxmemory long default=1073741824
## Maximum disk bloat factor per component before forcing flush.
-flush.memory.each.diskbloatfactor double default=0.2
+flush.memory.each.diskbloatfactor double default=0.25
## Age of unflushed content before forcing age prioritization.
## Unit is seconds with 31 hours being the default.