Merge pull request #22910 from vespa-engine/balder/no-need-to-copy-shared-ptr

Let ImportedAttributesRepo return a reference to a shared_ptr instead…

2 files changed, 3 insertions, 6 deletions

diff --git a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.cpp b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.cpp
index 28e609c17ef..7520d7e81d2 100644
--- a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.cpp
+++ b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.cpp
@@ -2,7 +2,6 @@
 
 #include "imported_tensor_attribute_vector.h"
 #include "imported_tensor_attribute_vector_read_guard.h"
-#include <vespa/eval/eval/value.h>
 
 namespace search::tensor {
 
@@ -34,9 +33,7 @@ ImportedTensorAttributeVector::ImportedTensorAttributeVector(vespalib::stringref
 {
 }
 
-ImportedTensorAttributeVector::~ImportedTensorAttributeVector()
-{
-}
+ImportedTensorAttributeVector::~ImportedTensorAttributeVector() = default;
 
 std::unique_ptr<attribute::AttributeReadGuard>
 ImportedTensorAttributeVector::makeReadGuard(bool stableEnumGuard) const
diff --git a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.h b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.h
index d39a8395595..853b2b54beb 100644
--- a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.h
+++ b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector.h
@@ -29,9 +29,9 @@ public:
                                   std::shared_ptr<attribute::ReadableAttributeVector> target_attribute,
                                   std::shared_ptr<const IDocumentMetaStoreContext> target_document_meta_store,
                                   std::shared_ptr<BitVectorSearchCache> search_cache);
-    ~ImportedTensorAttributeVector();
+    ~ImportedTensorAttributeVector() override;
 
-    virtual std::unique_ptr<attribute::AttributeReadGuard> makeReadGuard(bool stableEnumGuard) const override;
+    std::unique_ptr<attribute::AttributeReadGuard> makeReadGuard(bool stableEnumGuard) const override;
 };
 
 }