summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@online.no>2021-10-12 12:51:26 +0200
committerTor Egge <Tor.Egge@online.no>2021-10-12 12:51:26 +0200
commit23899cf262fee4bca3f92c25e85a4d269ad56161 (patch)
treee6745487ddd5ea6213afe93acf6f9698e25fccf2 /storage
parent041c1d8b834364da5788a864345f0cc32384de8b (diff)
Update metrics when we don't have source-only bucket copies.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp b/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp
index 7008cb36666..69bbb67b1f3 100644
--- a/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp
+++ b/storage/src/vespa/storage/distributor/operations/idealstate/mergeoperation.cpp
@@ -248,9 +248,9 @@ MergeOperation::deleteSourceOnlyNodes(
_ok = _removeOperation->ok();
done();
}
+ } else {
+ done();
}
- // FIXME what about the else-case here...? done() is not invoked by caller in this branch.
- // Not calling done() doesn't leak anything, but causes metric updates to be missed.
}
void