Remove the sync interface from Bucket Executor. Due to the nature of requiring a bucket lock it is very hard to get sync to work in a safe way.

Instead the users must do their own accounting as they know their own threading model.

2 files changed, 0 insertions, 9 deletions

diff --git a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
index c71a7fee424..7c175686359 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
@@ -49,10 +49,6 @@ public:
         return _executor.execute(bucket, std::move(task));
     }
 
-    void sync() override {
-        _executor.sync();
-    }
-
 private:
     spi::BucketExecutor & _executor;
 };
@@ -990,8 +986,4 @@ FileStorManager::execute(const spi::Bucket &bucket, std::unique_ptr<spi::BucketT
     return task;
 }
 
-void
-FileStorManager::sync() {
-}
-
 } // storage
diff --git a/storage/src/vespa/storage/persistence/filestorage/filestormanager.h b/storage/src/vespa/storage/persistence/filestorage/filestormanager.h
index 6eaef45e9bd..a48b4e0e208 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestormanager.h
+++ b/storage/src/vespa/storage/persistence/filestorage/filestormanager.h
@@ -175,7 +175,6 @@ private:
     void update_reported_state_after_db_init();
 
     std::unique_ptr<spi::BucketTask> execute(const spi::Bucket &bucket, std::unique_ptr<spi::BucketTask> task) override;
-    void sync() override;
 };
 
 } // storage