diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-10-19 14:55:07 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-19 14:55:07 +0200 |
commit | e71727da8dcc1eba0fce1b067772fe6c1c5b6f01 (patch) | |
tree | b5cbcc2f569d1a816e52d7d24defc025fad24563 /storage | |
parent | 63dd67087f6d12497b6fa577720225fb089aa7ba (diff) | |
parent | dc0df865ec553525cd0a410386c8e5f5331f471b (diff) |
Merge pull request #14946 from vespa-engine/vekterli/avoid-unsafe-functor-moving
Don't perform unsafe std::move of functor when it may be used again
Diffstat (limited to 'storage')
-rw-r--r-- | storage/src/vespa/storage/common/content_bucket_space_repo.h | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/storage/src/vespa/storage/common/content_bucket_space_repo.h b/storage/src/vespa/storage/common/content_bucket_space_repo.h index 6d8bd67b071..1c858e47bcd 100644 --- a/storage/src/vespa/storage/common/content_bucket_space_repo.h +++ b/storage/src/vespa/storage/common/content_bucket_space_repo.h @@ -28,25 +28,9 @@ public: size_t getBucketMemoryUsage() const; template <typename Functor> - void forEachBucket(Functor &functor, - const char *clientId) const { - for (const auto &elem : _map) { - elem.second->bucketDatabase().for_each(std::ref(functor), clientId); - } - } - - template <typename Functor> - void forEachBucketChunked(Functor &functor, - const char *clientId) const { - for (const auto &elem : _map) { - elem.second->bucketDatabase().for_each_chunked(std::ref(functor), clientId); - } - } - - template <typename Functor> void for_each_bucket(Functor functor) const { for (const auto& elem : _map) { - elem.second->bucketDatabase().acquire_read_guard()->for_each(std::move(functor)); + elem.second->bucketDatabase().acquire_read_guard()->for_each(functor); } } |