use LOG_ABORT not just abort()

* abort() has the unfortunate effect that nothing is seen in the log,
  just an event (which is usually not displayed); so ops people don't
  see that the program is crashing at all.
* LOG_ABORT("message") will log an error with the message (and the file
  and line) before calling abort(), so it's easy to see what happened.
* add or move <vespa/log/log.h> include and LOG_SETUP lines before
  LOG_ABORT is used (or included).

1 files changed, 3 insertions, 1 deletions

diff --git a/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp b/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp
index 09c805b2b85..affeae44c04 100644
--- a/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp
+++ b/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp
@@ -4,6 +4,8 @@
 #include "threadimpl.h"
 #include <vespa/vespalib/util/exceptions.h>
 #include <thread>
+#include <vespa/log/log.h>
+LOG_SETUP(".storageframework.thread_pool_impl");
 
 using namespace std::chrono_literals;
 using vespalib::IllegalStateException;
@@ -36,7 +38,7 @@ ThreadPoolImpl::~ThreadPoolImpl()
         if (i > 1000) {
             fprintf(stderr, "Failed to kill thread pool. Threads won't die. (And if allowing thread pool object"
                             " to be deleted this will create a segfault later)\n");
-            abort();
+            LOG_ABORT("should not be reached");
         }
         std::this_thread::sleep_for(10ms);
     }