aboutsummaryrefslogtreecommitdiffstats
path: root/testutil
diff options
context:
space:
mode:
authorJon Marius Venstad <jonmv@gmail.com>2022-04-04 11:59:40 +0200
committerJon Marius Venstad <jonmv@gmail.com>2022-04-04 11:59:40 +0200
commitc474a6250e57cb54ea83a3ff13706cfd36f96182 (patch)
tree90e23de38280d707b6e5aeccb116804a2d090026 /testutil
parenta0b02d8bd00bf8d7f3410cbf47ae432770546883 (diff)
Revert "Merge pull request #21961 from vespa-engine/revert-21918-jonmv/misc-6"
This reverts commit a0b02d8bd00bf8d7f3410cbf47ae432770546883, reversing changes made to 64d0102f9931a01d31976e85b585b9e63894f08e.
Diffstat (limited to 'testutil')
-rw-r--r--testutil/src/main/java/com/yahoo/test/OrderTester.java6
-rw-r--r--testutil/src/main/java/com/yahoo/test/TotalOrderTester.java2
2 files changed, 4 insertions, 4 deletions
diff --git a/testutil/src/main/java/com/yahoo/test/OrderTester.java b/testutil/src/main/java/com/yahoo/test/OrderTester.java
index 4acba4ee7fe..cc28ca9f469 100644
--- a/testutil/src/main/java/com/yahoo/test/OrderTester.java
+++ b/testutil/src/main/java/com/yahoo/test/OrderTester.java
@@ -15,8 +15,8 @@ import java.util.List;
*
*/
-public abstract class OrderTester<T extends Comparable<T>> {
- private ArrayList<List<T>> groups = new ArrayList<>();
+public abstract class OrderTester<T extends Comparable<? super T>> {
+ private final ArrayList<List<T>> groups = new ArrayList<>();
abstract protected void lessTest(T a, T b);
abstract protected void greaterTest(T a, T b);
@@ -24,7 +24,7 @@ public abstract class OrderTester<T extends Comparable<T>> {
@SafeVarargs
@SuppressWarnings("varargs")
- private final OrderTester<T> addGroup(T... group) {
+ private OrderTester<T> addGroup(T... group) {
groups.add(Arrays.asList(group));
return this;
}
diff --git a/testutil/src/main/java/com/yahoo/test/TotalOrderTester.java b/testutil/src/main/java/com/yahoo/test/TotalOrderTester.java
index 850369fbc2e..e95bc056ba8 100644
--- a/testutil/src/main/java/com/yahoo/test/TotalOrderTester.java
+++ b/testutil/src/main/java/com/yahoo/test/TotalOrderTester.java
@@ -20,7 +20,7 @@ import static org.junit.Assert.assertTrue;
* @author Vegard Sjonfjell
*/
-public class TotalOrderTester<T extends Comparable<T>> extends OrderTester<T> {
+public class TotalOrderTester<T extends Comparable<? super T>> extends OrderTester<T> {
protected void lessTest(T a, T b) throws AssertionError {
assertTrue(a + " must be less than " + b, a.compareTo(b) <= -1);
}