aboutsummaryrefslogtreecommitdiffstats
path: root/zkfacade
diff options
context:
space:
mode:
authorjonmv <venstad@gmail.com>2022-10-10 12:46:16 +0200
committerjonmv <venstad@gmail.com>2022-10-10 12:46:16 +0200
commita35e6897b69229669f7bdabdc0d57e7e7f6b879b (patch)
tree8d65ea86ebd0bd75d1fe0b73a29bdd918f08c438 /zkfacade
parent18ae654821153f51ba044e6a91157d1b8ff6310a (diff)
Disallow empty singleton IDs
Diffstat (limited to 'zkfacade')
-rw-r--r--zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java b/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java
index dd7d86bd26d..3bff9a1c3e0 100644
--- a/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java
+++ b/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java
@@ -46,8 +46,8 @@ class SingletonManager implements AutoCloseable {
}
synchronized CompletableFuture<?> register(String singletonId, SingletonWorker singleton) {
- if (singletonId.contains("/") || singletonId.contains("..")) {
- throw new IllegalArgumentException("singleton ID may not contain '/' or '..', but got " + singletonId);
+ if (singletonId.isEmpty() || singletonId.contains("/") || singletonId.contains("..")) {
+ throw new IllegalArgumentException("singleton ID must be non-empty, and may not contain '/' or '..', but got " + singletonId);
}
String old = registrations.putIfAbsent(singleton, singletonId);
if (old != null) throw new IllegalArgumentException(singleton + " already registered with ID " + old);