diff options
4 files changed, 18 insertions, 22 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java index 92e7bf0300b..d3f37eb320e 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java @@ -893,11 +893,10 @@ public class ApplicationRepository implements com.yahoo.config.provision.Deploye public void close() { metric.set(name, Duration.between(start, clock.instant()).toMillis(), - metric.createContext(Map.of("tenant", id.tenant().value(), - "application", id.application().value(), - "instance", id.instance().value(), - "environment", environment, - "region", region))); + metric.createContext(Map.of("applicationId", id.toFullString(), + "tenantName", id.tenant().value(), + "app", id.application().value() + "." + id.instance().value(), + "zone", environment + "." + region))); } } diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java index a963252d7ca..0e076d60d52 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java @@ -342,11 +342,10 @@ public class ApplicationRepositoryTest { new MockTesterClient(), actual); deployApp(testAppLogServerWithContainer); - Map<String, ?> context = Map.of("tenant", "test1", - "application", "testapp", - "instance", "default", - "environment", "prod", - "region", "default"); + Map<String, ?> context = Map.of("applicationId", "test1.testapp.default", + "tenantName", "test1", + "app", "testapp.default", + "zone", "prod.default"); MockMetric expected = new MockMetric(); expected.set("deployment.prepareMillis", 0L, expected.createContext(context)); expected.set("deployment.activateMillis", 0L, expected.createContext(context)); diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/JobMetrics.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/JobMetrics.java index a6ffb56492f..5df914bad80 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/JobMetrics.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/JobMetrics.java @@ -40,12 +40,11 @@ public class JobMetrics { } Map<String, String> contextOf(JobId id) { - return Map.of("tenant", id.application().tenant().value(), - "application", id.application().application().value(), - "instance", id.application().instance().value(), - "job", id.type().jobName(), - "environment", id.type().environment().value(), - "region", id.type().zone(system).region().value()); + return Map.of("applicationId", id.application().toFullString(), + "tenantName", id.application().tenant().value(), + "app", id.application().application().value() + "." + id.application().instance().value(), + "test", Boolean.toString(id.type().isTest()), + "zone", id.type().zone(system).value()); } static String valueOf(RunStatus status) { diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java index 9de0020ce4a..b3a6ef53d2b 100644 --- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java +++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java @@ -375,12 +375,11 @@ public class JobRunnerTest { jobs.finish(jobs.last(id, systemTest).get().id()); } - Map<String, String> context = Map.of("tenant", "tenant", - "application", "real", - "instance", "default", - "job", "system-test", - "environment", "test", - "region", "us-east-1"); + Map<String, String> context = Map.of("applicationId", "tenant.real.default", + "tenantName", "tenant", + "app", "real.default", + "test", "true", + "zone", "test.us-east-1"); MetricsMock metric = ((MetricsMock) tester.controller().metric()); assertEquals(RunStatus.values().length - 1, metric.getMetric(context::equals, JobMetrics.start).get().intValue()); assertEquals(1, metric.getMetric(context::equals, JobMetrics.abort).get().intValue()); |