1 files changed, 129 insertions, 0 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java
new file mode 100644
index 00000000000..17dc9e643f0
--- /dev/null
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java
@@ -0,0 +1,129 @@
+package ai.vespa.metricsproxy.service;
+
+import ai.vespa.metricsproxy.metric.Metric;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+
+/**
+ * @author gjoranv
+ */
+public class MetricsParserTest {
+
+    private static class MetricsCollector implements MetricsParser.Collector {
+        List<Metric> metrics = new ArrayList<>();
+
+        @Override
+        public void accept(Metric metric) {
+            metrics.add(metric);
+        }
+    }
+
+    @Test
+    public void different_dimension_values_are_not_treated_as_equal() throws Exception {
+        var collector = new MetricsCollector();
+        MetricsParser.parse(metricsJsonDistinctButDuplicateDimensionDalues(), collector);
+        assertEquals(2, collector.metrics.size());
+        assertNotEquals("Dimensions should not be equal",
+                        collector.metrics.get(0).getDimensions(),
+                        collector.metrics.get(1).getDimensions());
+    }
+
+    @Test
+    public void different_swapped_dimension_values_are_not_treated_as_equal() throws Exception {
+        var collector = new MetricsCollector();
+        MetricsParser.parse(metricsJsonDistinctButDuplicateSwappedDimensionDalues(), collector);
+        assertEquals(2, collector.metrics.size());
+        assertNotEquals("Dimensions should not be equal",
+                collector.metrics.get(0).getDimensions(),
+                collector.metrics.get(1).getDimensions());
+    }
+
+    // The duplicate dimension values for 'cluster' and 'clusterid' exposed a bug in a previously used hashing algo for dimensions.
+    private String metricsJsonDistinctButDuplicateDimensionDalues() {
+        return """
+                {
+                  "time": 1671035366573,
+                  "status": {
+                    "code": "up"
+                  },
+                  "metrics": {
+                    "snapshot": {
+                      "from": 1671035306.562,
+                      "to": 1671035366.562
+                    },
+                    "values": [
+                      {
+                        "name": "cluster-controller.resource_usage.nodes_above_limit",
+                        "values": {
+                          "last": 1.0
+                        },
+                        "dimensions": {
+                          "controller-index": "0",
+                          "cluster": "CLUSTER-1",
+                          "clusterid": "CLUSTER-1"
+                        }
+                      },
+                      {
+                        "name": "cluster-controller.resource_usage.nodes_above_limit",
+                        "values": {
+                          "last": 2.0
+                        },
+                        "dimensions": {
+                          "controller-index": "0",
+                          "cluster": "CLUSTER-2",
+                          "clusterid": "CLUSTER-2"
+                        }
+                      }
+                    ]
+                  }
+                }
+                """;
+    }
+    // The duplicate dimension values for 'cluster' and 'clusterid' exposed a bug in a previously used hashing algo for dimensions.
+    private String metricsJsonDistinctButDuplicateSwappedDimensionDalues() {
+        return """
+                {
+                  "time": 1671035366573,
+                  "status": {
+                    "code": "up"
+                  },
+                  "metrics": {
+                    "snapshot": {
+                      "from": 1671035306.562,
+                      "to": 1671035366.562
+                    },
+                    "values": [
+                      {
+                        "name": "cluster-controller.resource_usage.nodes_above_limit",
+                        "values": {
+                          "last": 1.0
+                        },
+                        "dimensions": {
+                          "controller-index": "0",
+                          "cluster": "CLUSTER-1",
+                          "clusterid": "CLUSTER-2"
+                        }
+                      },
+                      {
+                        "name": "cluster-controller.resource_usage.nodes_above_limit",
+                        "values": {
+                          "last": 2.0
+                        },
+                        "dimensions": {
+                          "controller-index": "0",
+                          "cluster": "CLUSTER-2",
+                          "clusterid": "CLUSTER-1"
+                        }
+                      }
+                    ]
+                  }
+                }
+                """;
+    }
+
+}