aboutsummaryrefslogtreecommitdiffstats
path: root/vespajlib/src/main/java/com/yahoo/tensor/TensorType.java
diff options
context:
space:
mode:
Diffstat (limited to 'vespajlib/src/main/java/com/yahoo/tensor/TensorType.java')
-rw-r--r--vespajlib/src/main/java/com/yahoo/tensor/TensorType.java12
1 files changed, 6 insertions, 6 deletions
diff --git a/vespajlib/src/main/java/com/yahoo/tensor/TensorType.java b/vespajlib/src/main/java/com/yahoo/tensor/TensorType.java
index aaa25a0b058..df78f3dfc3a 100644
--- a/vespajlib/src/main/java/com/yahoo/tensor/TensorType.java
+++ b/vespajlib/src/main/java/com/yahoo/tensor/TensorType.java
@@ -4,6 +4,7 @@ package com.yahoo.tensor;
import com.google.common.collect.ImmutableList;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.LinkedHashMap;
@@ -410,7 +411,7 @@ public class TensorType {
private final Value valueType;
- /** Creates an empty builder with cells of type double*/
+ /** Creates an empty builder with cells of type double */
public Builder() {
this(Value.DOUBLE);
}
@@ -425,17 +426,16 @@ public class TensorType {
* If the same dimension is indexed with different size restrictions the largest size will be used.
* If it is size restricted in one argument but not the other it will not be size restricted.
* If it is indexed in one and mapped in the other it will become mapped.
+ *
+ * The value type will be the largest of the value types of the input types
*/
public Builder(TensorType ... types) {
- this(Value.DOUBLE, types);
- }
- public Builder(Value valueType, TensorType ... types) {
- this.valueType = valueType;
+ this.valueType = TensorType.Value.largestOf(Arrays.stream(types).map(type -> type.valueType()).collect(Collectors.toList()));
for (TensorType type : types)
addDimensionsOf(type);
}
- /** Creates a builder from the given dimensions */
+ /** Creates a builder from the given dimensions, having double as the value type */
public Builder(Iterable<Dimension> dimensions) {
this(Value.DOUBLE, dimensions);
}